Question

[Aegnor]

here comes a question to the all-powerful "sages of IE wisdom".. (a.k.a the PP modders...)

I've been working on a familiar mod... (see signature if your interested (self-promotion is baaad m'kay...) )
Well whatever... So I ran in to a problem... In the mod, I have removed control over the familiar, (made it neutral)
but I still want it to obey commands during combat so I wrote this script..

IF
  !Global("FamIsGreen","LOCAL",1)
  !CombatCounter(0)
THEN
    RESPONSE #100
             AddFamiliar()
             SetGlobal("FamIsGreen","LOCAL",1)
END

IF
  Global("FamIsGreen","LOCAL",1)
  CombatCounter(0)
THEN
    RESPONSE #100
             RemoveFamiliar()
             SetGlobal("FamIsGreen","LOCAL",0)
END

Well it works somewhat.. but during combat I gain control over it for a while and then for no reason
I can detect it becomes neutral then it becomes an ally again.
The time is somewhat like: neutral for 2 seconds then it is green for 5-10 seconds.
and it keeps doing that.

I've tried replacing it with:
ChangeEnemyAlly(Myself,NEUTRAL) and
ChangeEnemyAlly(Myself,FAMILIAR),
but then it never changes at all.


Any help would be appric..appris... help would make my black cold heart go warm with fuzzy feelings...

Argh... Pirates!
                                                                                                                                                                                                                                                                                                                                               

[igi_g]

Assuming they are not a typo's, you want to use LOCALS not LOCAL. And both blocks check for FamIsGreen being 1.

You could try using ActuallyInCombat() instead of CombatCounter.

[Aegnor]

heh.. no it wasen't a typo.. copy-pasted from the code.. strange i diden't get an error for this...
thx, i'll try this when I get home...

this would explain why ChangeEnemyAlly(Myself,NEUTRAL) and
ChangeEnemyAlly(Myself,FAMILIAR), woulden't work...

But this makes me even more confused about the function of AddFamiliar()..
Since I made this mistake, the code never used RemoveFamiliar.. if this is true
it means that AddFamiliar() is time based.. unless it was a result of the code
keep doing the AddFamiliar() action, even though it already was assigned.

[Ghreyfain]

This is a totally random guess, but AddFamiliar() sounds a lot like the MakeGlobal() action.  I think it just adds the creature to the saved game as a familiar.

What you probably want is the ChangeEnemyAlly() stuff, and make sure your checks are working properly.  What I think is happening is that the very flaky CombatCounter is setting to 0, and it's just setting your familiar back to his non-combat state.

Did you try what igi suggested?

Also, you don't need the LOCALS in there.  I suggest a simple check for Allegiance(Myself,NEUTRAL) and FAMILIAR.

[Loriel]

ActuallyInCombat() is a TOB-specific trigger.  If you want this to work in vanilla SOA, you will want to put something like this near the top of your TP2:

Code: [Select]

APPEND ~trigger.ids~ ~0x40D5 ActuallyInCombat()~
    UNLESS ~ActuallyInCombat()~


[devSin]

Don't ever, ever, ever use !CombatCounter(0). Dialogue, among other things, tends to jiggle the combat counter for some reason. If you want to see if a party is in combat, use CombatCounterGT(0), and to check if they're not in combat, use CombatCounter(0) (or, you can use CombatCounterLT(1), depending on how precise you need the check to be).

I don't know that anybody really knows all the cases where ActuallyInCombat() will evaluate to true. I don't think it will do anything unless the specific character is doing something combat-related, so it probably won't work in your script.

[Aegnor]

Heh.. tried it now... and it works flawlessly.. (useing ChangeEnemyAlly() not tried AddFamiliar())
I'll use ActuallyInCombat() for the time being.. they're many other things I have to change if I want my mod in vanilla bg2..

thanks for the help everyone..

[jcompton]

Don't ever, ever, ever use !CombatCounter(0). Dialogue, among other things, tends to jiggle the combat counter for some reason. If you want to see if a party is in combat, use CombatCounterGT(0), and to check if they're not in combat, use CombatCounter(0) (or, you can use CombatCounterLT(1), depending on how precise you need the check to be).

Except I thought it was the other way around, that CombatCounterGT was the broken one...

[devSin]

that CombatCounterGT was the broken one

Not that I'm aware of. The only thing I've experienced is that dialogue will tend to mess with the combat counter; when this happens, !CombatCounter(0) will erroneously return true and CombatCounterGT(0) will return false.