Author Topic: Needed changes for BG:EE  (Read 1493 times)

Offline jastey

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 1524
  • Gender: Female
Needed changes for BG:EE
« on: May 05, 2023, 10:46:08 AM »
The changes to Ivanne in chapter 7 need to be adapted for BG:EE.
This is what bg1ub is currently doing:
Code: [Select]
//IVANNE, AR0114 - tells player his story, refers to Iron Throne and Eltan. (J)
ADD_TRANS_ACTION %tutu_var%IVANNE
BEGIN 5 END
BEGIN 0 END
~SetGlobal("TalkedToIvanne","GLOBAL",1)~ //told his story

REPLACE_STATE_TRIGGER %tutu_var%IVANNE 0 ~Global("TalkedToIvanne","GLOBAL",0)~ //won't tell his story twice

ADD_TRANS_TRIGGER %tutu_var%IVANNE 5
~!Dead("Cythan")
!Dead("Rashad")~
DO 0

EXTEND_BOTTOM %tutu_var%IVANNE 5
IF ~Dead("Cythan") !Dead("Rashad")~ THEN JOURNAL @1 DO ~SetGlobal("TalkedToIvanne","GLOBAL",1)~ EXIT
IF ~!Dead("Cythan") Dead("Rashad")~ THEN JOURNAL @2 DO ~SetGlobal("TalkedToIvanne","GLOBAL",1)~ EXIT
IF ~Dead("Cythan") Dead("Rashad")~ THEN JOURNAL @3 DO ~SetGlobal("TalkedToIvanne","GLOBAL",1)~ EXIT
END

This is what it should be doing:
Code: [Select]
//IVANNE, AR0114 - tells player his story, refers to Iron Throne and Eltan.

ADD_TRANS_TRIGGER %tutu_var%IVANNE 5
~!Dead("Cythan")
!Dead("Rashad")~
DO 0

EXTEND_BOTTOM %tutu_var%IVANNE 5
IF ~Dead("Cythan") !Dead("Rashad")~ THEN DO ~SetGlobal("IvanneStoryTold","GLOBAL",1)
EraseJournalEntry(27178)
EraseJournalEntry(27177)
~ SOLVED_JOURNAL @1 EXIT
IF ~!Dead("Cythan") Dead("Rashad")~ THEN DO ~SetGlobal("IvanneStoryTold","GLOBAL",1)
EraseJournalEntry(27178)
EraseJournalEntry(27177)
~ SOLVED_JOURNAL @2 EXIT
IF ~Dead("Cythan") Dead("Rashad")~ THEN DO ~SetGlobal("IvanneStoryTold","GLOBAL",1)
EraseJournalEntry(27178)
EraseJournalEntry(27177)
~ SOLVED_JOURNAL @3 EXIT
END

Offline Isewein

  • Planewalker
  • *****
  • Posts: 33
Re: Needed changes for BG:EE
« Reply #1 on: March 10, 2024, 06:08:07 PM »
Which file does this have to be changed in? Just about to set up a reinstall and thinking I might as well incorporate recent fixes floating around such as this manually...

Offline jastey

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 1524
  • Gender: Female
Re: Needed changes for BG:EE
« Reply #2 on: March 11, 2024, 02:18:45 AM »
It's in dialogues/u!ch7.d and dialogues/cpm/u!ch7.d. I'm not sure which one gets used for EE.

Offline Frenz

  • Planewalker
  • *****
  • Posts: 6
Re: Needed changes for BG:EE
« Reply #3 on: March 11, 2024, 09:22:20 AM »
Looking at "bg1ub_dialogues.tpa", the one used in BGEE should be  "/dialogues/u!ch7.d"

Here's the code:

Code: [Select]
///// Minor Dialogue Restorations                      \\\\\

ACTION_IF !GAME_IS ~bg1 totsc~ THEN BEGIN
  COMPILE EVALUATE_BUFFER ~bg1ub/dialogues/cpm/u!minor1.d~
  COMPILE EVALUATE_BUFFER ~bg1ub/dialogues/cpm/u!ch7.d~
  COMPILE EVALUATE_BUFFER ~bg1ub/dialogues/cpm/ubhobgo5.baf~
END ELSE BEGIN
  COMPILE EVALUATE_BUFFER ~bg1ub/dialogues/u!minor1.d~
  COMPILE ~bg1ub/dialogues/u!ch7.d~
  COMPILE ~bg1ub/dialogues/ubhobgo5.baf~
END

Am I wrong or the related "ELSE" block lacks two EVALUATE_BUFFER?


Offline jastey

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 1524
  • Gender: Female
Re: Needed changes for BG:EE
« Reply #4 on: March 15, 2024, 12:49:42 PM »
Without checking, I'd assume that the versions for bg1 do not include variables that need to be evaluated.

Offline Frenz

  • Planewalker
  • *****
  • Posts: 6
Re: Needed changes for BG:EE
« Reply #5 on: March 19, 2024, 04:19:53 PM »
For what it's worth, I just opened a PR with the change you mentioned.

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: