BG1 UB problem with bringing corpse to Arkion

[jacklhoward]

I was unable to have Arkion accept two corpses for his quest. Also the journal wouldn't update and the quest was not marked as completed after talking to him.

A friend called Graion Dilach from discord pointed out the possible cause for this bug, he says:

"~BG1UB/SETUP-BG1UB.TP2~ #0 #11 // Scar and the Sashenstar's Daughter: v16.4˙

This one is the problem, it introduces an almost duplicate dlg entry of the single-corpse accepting response weighted above the multi-accepter response"

Also does the scar and the sashenstar's daughter component conflict with vanilla bgee v.2.660? I noticed the mod moved the noblewomans ring to the sac and renamed it. Would that cause conflicts if the quest wants the original ring in the game?

[Graion Dilach]

I was unable to have Arkion accept two corpses for his quest. Also the journal wouldn't update and the quest was not marked as completed after talking to him.

Filed a fix for this in https://github.com/Pocket-Plane-Group/bg1ub/pull/2. I also noticed during testing that BGT also adds a journal entry to this quest which remains unsolved if one uses this option and the multi-body option might also get blocked there now (oBG1 has the multi-body response garbled if I see that one right with a bugged trigger index and the response doesn't take the bodies even, but I am not that familiar with oBG1 coding to know what to suggest there).

Also does the scar and the sashenstar's daughter component conflict with vanilla bgee v.2.660? I noticed the mod moved the noblewomans ring to the sac and renamed it. Would that cause conflicts if the quest wants the original ring in the game?

I'll check this one.

[Graion Dilach]

I think I'll be taking a more drastic approach here. I haven't looked at Tutu yet (and will install it for this) but I think the triggers and actions of Arkion's dialogue should be patched instead of adding new entries to the dialog to cover the female bodies. The fact that the tree differs between all three games I looked at so far (oBG/BGT/BGEE) already. I'll try to come up with something during the weekend for this one.

[Salk]

I'm not able to test at the moment but I think what we need to completely rewrite ubscar_classic.d swapping this:

Code: [Select]

REPLACE_STATE_TRIGGER %tutu_var%ARKION 6 ~Global("HelpArkion","GLOBAL",1)~


APPEND %tutu_var%ARKION
IF WEIGHT #0 ~Global("HelpArkion","GLOBAL",0)
PartyHasItem("%tutu_scriptbg%MISC79")~ THEN BEGIN EitherBody
  SAY @0
  IF ~PartyHasItem("%tutu_scriptbg%MISC79")~ THEN DO ~SetGlobal("HelpArkion","GLOBAL",1) TakePartyItem("%tutu_scriptbg%MISC79") GivePartyGold(250) AddexperienceParty(1800)~ EXIT
END

IF WEIGHT #0 ~Global("HelpArkion","GLOBAL",0)
PartyHasItem("UBFEBODY")~ THEN BEGIN NobleBody
  SAY @16
  IF ~~ THEN EXIT
END
END
with this:

Code: [Select]

/* ARKION
  - all eligible corpses are taken from the Players by Arkion */
REPLACE_STATE_TRIGGER %tutu_var%ARKION 3 ~Global("HelpArkion","GLOBAL",0) OR(2) NumItemsParty("MISC79",1) NumItemsParty("MISC80",1)~
REPLACE_STATE_TRIGGER %tutu_var%ARKION 4 ~Global("HelpArkion","GLOBAL",0) OR(2) NumItemsPartyGT("MISC79",0) NumItemsPartyGT("MISC80",0) OR(2) NumItemsPartyGT("MISC79",1) NumItemsPartyGT("MISC80",0) OR(2) NumItemsPartyGT("MISC80",1) NumItemsPartyGT("MISC79",0)~
REPLACE_STATE_TRIGGER %tutu_var%ARKION 6 ~Global("HelpArkion","GLOBAL",1)~
REPLACE_TRANS_ACTION %tutu_var%ARKION BEGIN 3 END BEGIN END ~TakePartyItem("MISC80")~ ~TakePartyItem("MISC79") TakePartyItem("MISC80")~
REPLACE_TRANS_ACTION %tutu_var%ARKION BEGIN 4 END BEGIN END ~TakePartyItemAll("MISC80")~ ~TakePartyItemAll("MISC79") TakePartyItemAll("MISC80")~

APPEND %tutu_var%ARKION
IF WEIGHT #0 ~Global("HelpArkion","GLOBAL",0)
PartyHasItem("UBFEBODY")~ THEN BEGIN NobleBody
  SAY @16
  IF ~~ THEN EXIT
END
END