Author Topic: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.  (Read 3567 times)

Offline AL|EN

  • Planewalker
  • *****
  • Posts: 391
  • Gender: Male
Hi,
recently It come to me that:

Quote
So, for example, if a user has installed (or simply extracted) v4 of a mod (where the .tp2 resides in the game folder), and later downloads a v5 where the .tp2 has been moved to the mod folder, they will need to ensure they DELETE the existing .tp2 from their game directory before installing the mod. Otherwise, the installation will use the v4 .tp2 found in the game folder rather than the v5 .tp2 in the mod folder.

I don't know the weidu technical stuff so if this won't cause problems can you change this order to use tp2 file inside mod folder?
Project Infinity public BETA - mod manager for Infinity Engine games
Modder's Guide to Github - you cannot have progress without committing changes

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
The only potential problem I can think of is if some mod ships with both (setup-)mymod.tp2 and mymod/(setup-)mymod.tp2 and intends for (setup-)mymod.tp2 to be used. I don't know of any mods that do that, but they can certainly exist.

However, is there any reason beyond fussiness for making this change?
The current load order allows old mods to continue to work as they always have and allows new mods to place their TP2 in the mod folder. There explicitly never was any promise this would be useful for moving the TP2 of old mods.

Offline AL|EN

  • Planewalker
  • *****
  • Posts: 391
  • Gender: Male
Maybe there wasn't any promise this would be useful for moving the TP2 of old mods, but the way it's implemented practically prevents of updating old mod and move tp2 file. There might be some value in cleanup but if you think that is fussiness then i'm sorry to bother you when you surely have more important things to do.
Project Infinity public BETA - mod manager for Infinity Engine games
Modder's Guide to Github - you cannot have progress without committing changes

Offline The Imp

  • Planewalker
  • *****
  • Posts: 288
  • Gender: Male
The only potential problem I can think of is if some mod ships with both (setup-)mymod.tp2 and mymod/(setup-)mymod.tp2 and intends for (setup-)mymod.tp2 to be used. I don't know of any mods that do that, but they can certainly exist.

However, is there any reason beyond fussiness for making this change?
Erhm, if you take imp-ut, it's more likely to be an issue with prioritizing one over the other... as it's not asked which one is to be used, the weidu.exe is backwarding to the default file, and not to the likely more up to date one.

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
There might be some value in cleanup but if you think that is fussiness then i'm sorry to bother you when you surely have more important things to do.
I'm not unsympathetic (I'm fussy too). But as it is now, it would be against my better judgement (but that guy's an idiot).

I'm totally open to having a vote or whatever on this. We have two Ayes, any Nays?

Offline CamDawg

  • Infidel
  • Planewalker
  • *****
  • Posts: 865
  • Dreaming of a red Xmas
    • The Gibberlings Three
Nah--I feel like this is just asking for some dumb regression somewhere. However, since this seems to be something to help out BWS, perhaps a command-line switch to alter tp2 search order would work as an alternative?

The only potential problem I can think of is if some mod ships with both (setup-)mymod.tp2 and mymod/(setup-)mymod.tp2 and intends for (setup-)mymod.tp2 to be used. I don't know of any mods that do that, but they can certainly exist.
Also, there's a limit to what we can do to protect idiots from themselves. :)
The Gibberlings Three - Home of IE Mods

The BG2 Fixpack - All the fixes of Baldurdash, plus a few hundred more. Now available, with more fixes being added in every release.

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #6 on: August 01, 2014, 11:27:37 AM »
However, since this seems to be something to help out BWS, perhaps a command-line switch to alter tp2 search order would work as an alternative?
Well, unless it was default, mods would not ship with their TP2 moved to the mod folder. At that point, BW* may as well move setup-foo.tp2 to foo\ without any change needed in WeiDU.

Offline Almateria

  • Planewalker
  • *****
  • Posts: 76
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #7 on: August 10, 2014, 08:08:02 AM »
Yo, I'm a nontechnical woman/child, but would it be feasinle to make the weidu compare two working tp2s and load the one with a higher VERSION?

Offline Argent77

  • Planewalker
  • *****
  • Posts: 188
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #8 on: August 10, 2014, 10:28:27 AM »
Unfortunately, VERSION is optional and accepts anything in string format without complaint. You can specify "3.0", "v3beta5 (from December 24, 2013)" or even "super special edition". A numeric compare will surely fail in the latter two cases and a string compare won't always return the correct result.

Offline Almateria

  • Planewalker
  • *****
  • Posts: 76
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #9 on: August 10, 2014, 01:59:02 PM »
Just force people to conform to the better standard
Like Apple

Offline AL|EN

  • Planewalker
  • *****
  • Posts: 391
  • Gender: Male
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #10 on: February 10, 2015, 02:49:37 AM »
Can we change this in the next BETA and see what's come up?
Project Infinity public BETA - mod manager for Infinity Engine games
Modder's Guide to Github - you cannot have progress without committing changes

Offline jastey

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 1524
  • Gender: Female
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #11 on: February 10, 2015, 12:00:24 PM »
Missed this thread until now.
I'd favor the tp2 in the mod folder being executed with higher priority than a tp2 in the main game folder.

tp2 inside the mod folder is nowadays standard, but old mods cannot be shipped with the tp2 in the mod folder instead of the main folder because risk is players forget to delete the old one. BG1NPC Project v20 still ships the tp2 at mod folder level because of this, for example. I had a very, very stupid "bug" on my own mod install because I didn't think of an old tp2 still being present in the game folder that took me way too long to realize what is going on - my own mistake, I know, but this is what could happen to some players.

I am definitely for shipping the tp2 inside the mod folder as it decreses the amount of files I have to move around when testing mods in my x+ BG installs, so this request would be something I second.

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #12 on: March 01, 2015, 07:50:01 AM »
I haven't been ignoring this, but as you have probably surmised, it is not going into this next version. Maybe the version after that.

Offline AL|EN

  • Planewalker
  • *****
  • Posts: 391
  • Gender: Male
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #13 on: December 20, 2015, 05:31:18 AM »
Bump for having this before 240 ;)
Project Infinity public BETA - mod manager for Infinity Engine games
Modder's Guide to Github - you cannot have progress without committing changes

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
Re: The "reads-tp2-from-mod-dir" feature is almost useles for old mods.
« Reply #14 on: January 06, 2016, 03:32:55 PM »
Done.

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: