v1.33b20 Issues / Suggestions

[devSin]

OK, I see now the were-silver vs. iron-were split and agree it was probably originally designed to support both when they were building the engine (even though it was never used that way and pretty much dropped after TotSC). It'll change back to Cold iron at some future point, thanks.

[Taimon]

Did a new merge today and also pushed your branch that I keep locally dev - just in case I delete it accidentally.

[devSin]

Cool.

If anybody is wondering (like anybody cares), it's almost exclusively small improvements to Icewind Dale II editing.

Barring label changes, this is probably the end of the line, folks. It's been fun.

[Taimon]

New merge, thanks devSin.

[ScuD]

Got a question here. NI reports some WAV files as missing, but they are in the game and can be clearly seen in the tree on the left. Can be played. But when checking area's ambient there's no such a file in the list below the Edit pane.
So how can it be so?

[devSin]

In ARE resources, NI tries to list only sounds from uncompressed BIFFs and the compressed BIFF containing the area's WED (since the game can only access one compressed BIFF at a time, and it's always going to be the one containing the area's tileset and WED).

[ScuD]

As I understand, uncompressed BIFF = file in the override folder. So it is in override, not in another BIFF, but not in the list.

[ScuD]

2 more issues to report. Running Tools -> Find Mis-indexed Effects results in 2 exceptions in the console:

Code: [Select]

Could not find attribute Effects index in Item ability
Exception in thread "Thread-20" java.lang.NullPointerException
        at infinity.check.EffectsIndexChecker.search(Unknown Source)
        at infinity.check.EffectsIndexChecker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)and

Code: [Select]

Could not find attribute Effects index in Spell ability
Exception in thread "Thread-21" java.lang.NullPointerException
        at infinity.check.EffectsIndexChecker.search(Unknown Source)
        at infinity.check.EffectsIndexChecker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

[devSin]

Yeah, my fault. I changed the labels for some reason and neglected to change this.

I'm not sure about the ARE sound resource without looking at the source (don't have time nor desire to). There's a custom class for those; I made a change early on to fix where it was looking, but I didn't look too much into the overall behavior (vs. just listing all known WAV resources) beyond seeing that it was made to keep out all but the "active" compressed BIFF. I don't think it ever worked right--likely Jon never got to finish it--so it's probably worth checking to see if it should be rewritten or just dropped altogether (we don't too much try to pretend to be more clever than the user in other areas that I'm aware of, so if you do something wrong, we should let you and the game will crash and you'll know better next time).

[the bigg]

Compatibility with ToBEx:

Code: [Select]

--- resource/bcs/Decompiler.java.old    2011-02-18 13:00:46.561786492 +0100
+++ resource/bcs/Decompiler.java        2011-02-18 13:02:30.902307798 +0100
@@ -188,7 +188,9 @@
       if (token.equalsIgnoreCase("TR")) {
         String trigger = decompileTR(st);
         if (orcount > 0) {
-          orcount--;
+          if (trigger.substring(0,19).equalsIgnoreCase("NextTriggerObject(")) {
+               orcount--;
+       }
           code.append(indent);
         }
         else if (trigger.substring(0, 3).equalsIgnoreCase("OR("))


[Viktor]

Suggestion, it is possible to classified the effects in alphabetic order like the old version ?