Author Topic: I guess this is Virtue's fault... (Read 23932 times)

the bigg · « **on:** March 16, 2006, 09:09:22 AM »

When Kivan, Saerileth, or Yasraena join the party, they immediatly go on with their 'did you ask me to leave?' dialogue (IE 'P' variant when being booted) before joining for good, get the J/B dialogue once joined, and when they leave they still get their J dialogue, rather than swithching to the P one, don't come asking you 'did you ask me to leave' and if talked to, still say their J lines. Kelsey did not have these bugs. This is especially annoying since both Yasraena and Saerileth get kidnapped at a point during their storyline, and I have to save, NI the dialogue from J to P, and reload.

I believe that all that is needed would be to do those EXTEND_BOTTOMS in a regexp fashion for all NPCs. If you can't be bothered, I'll whip something up ASAP.

(if this is not Virtue's fault, send your assassins to my house).

Grim Squeaker · « **Reply #1 on:** March 16, 2006, 10:13:49 AM »

Interesting. Icelus had a similar bug when he was testing Jelina for me and he thinks its possible he had Virtue installed at the time, though he's not sure.

the bigg · « **Reply #2 on:** March 16, 2006, 02:29:39 PM »

Santa's working even in the wrong occasions

Notes:
1) I extend both SoA and ToB scripts with the various portions of code about variable handling and such. The header (= lose rep + the various VocalCostants) are repeated for the 3 alignments to cover cases such as Viconia/Sarevok.
2) only the SoA P dialogue is patched. I see that this is not done for the ToB one. Also, you should double-check for NPCS that can change alignment (IE, viconia and Sarevok, and eventual others I do not recall about). Not easy to do in generic loops

(Umm, I see you do so in viconip. Isn't that the SoA variant?). AnomenP, for instance, is NOT patched.
3) I've tried installing it, but haven't checked completely the output. A quick check in Kivan makes me think that it works.
4) Valygar still gets his special 'drop body when killed' treatment. Any other special treatment via the scripts are not.
5) Did I say that this should be checked a lil' more?

EDIT: 6) requires WeiDU 191 for FILE_EXISTS_IN_GAME ~%foo%~

the bigg · « **Reply #3 on:** August 27, 2006, 07:58:51 AM »

Quick update: since WizWoz is an usual BWL-like modder and Baronius is licking his balls, this tp2 upgrade won't be compatible with any mod made by WizWoz, nor there is any way around this.

SimDing0™ · « **Reply #4 on:** August 27, 2006, 08:05:39 AM »

Can you copy anything in that thread that impacts on me? I'm still banned from BWL, and alternative methods of reading it are slow. Thanks.

the bigg · « **Reply #5 on:** August 27, 2006, 08:12:52 AM »

Basically, WW is using W^ as his prefix. Somewhere in the tp2 above, I'm looking for regexp ~^%SOURCE_RES%$~ and ~^%death_variable%$~ in a number of files; when it meets W^ files, it'll look for ~^w^something$~, whereas it should be looking for ~^w\^something%~ (with the second ^ escaped, since it's the character and not a start-of-line).

The full thread: http://www.weidu.org/~thebigg/extra/wizwoz.html

SimDing0™ · « **Reply #6 on:** August 27, 2006, 09:05:56 AM »

I hate people.

WizWom · « **Reply #7 on:** August 28, 2006, 01:16:50 PM »

First:
The snide attitude is not needed.
Second:
This is a lingering bug in WeiDU, from having a (probably needless) hack around the glob code. Do not take this to mean I will ignore it, I will not. If it really is a problem, I shall do whatever is needed to not cause trouble and be compatable.

Gorilym · « **Reply #8 on:** August 28, 2006, 01:23:28 PM »

A thought occurs, perhaps it would be a good idea to post a link for this patch on the Virtue download page?

the bigg · « **Reply #9 on:** August 28, 2006, 01:41:41 PM »

Quote from: WizWom on August 28, 2006, 01:16:50 PM

This is a lingering bug in WeiDU, from having a (probably needless) hack around the glob code. Do not take this to mean I will ignore it, I will not. If it really is a problem, I shall do whatever is needed to not cause trouble and be compatable.

IT'S NOT THE GLOB PROBLEM, IT'S THE REGEXP PROBLEM. I just tested and the bug is there: namely, Jon is kicked out of party as soon as he joins, because Virtue can't find "^%death_variable%[ \t]" inside PDIALOG.2DA and thus the tp2 doesn't edit his script, thereby causing the kick-out bug.

EDIT: my posts in a totally different forum, apparently, are cause enough to ban my IP from BWL. Way to go.

WizWom · « **Reply #10 on:** August 28, 2006, 02:37:40 PM »

OK, yes, SimDing0 made a crappy mod. And don't get me started on the shittiness of mod TP2 coding, I'll rip into Kelsey like a scaling knife into acarp. s'okay, I'm exploring the issue. Like I said, if it's a problem, I'll use a different prefix. Frankly, though, I don't trust you to know WTF you're doing, sorry.
Installing Jonathan after virtue gives that behavior, yes.
Installing Virtue after Jonathan and Kelsey, I see neither of their scripts in the backup\0 directory, so, as reported, standard Virtue is brain dead about ALL extra NPCs, not just mine. So, I've got the patch, let me look at what you did here.

First off, your patch is nice and elegent, I like it. Bad, very bad form not to quote an exact striing you are using later, but a common error. And, indeed, it does not patch my poor NPC.

First: get rid of '^' for any file name globs - pointless. filenames are a string of the name, the cannot help but be the start of a line.

OK, so, yes, the generic AllNPC patch code you made does not handle a DV of W^Jon correctly, even when escaped (i am not surprised, the GLOB function, as I said already, is broken, and XP does something wierd with the ^ in the filename).

Well, it seems WxJon works, so I suppose W^Jon was confusing it. I will not use it. simple, see?

the bigg · « **Reply #11 on:** August 28, 2006, 02:50:02 PM »

Quote from: WizWom on August 28, 2006, 02:37:40 PM

Well, it seems WxJon works, so I suppose W^Jon was confusing it. I will not use it. simple, see?

Yeah, well, simple we'll call it

Obviously, if I had been this clear, like, 30 hours ago, I'd still be able to browse and post on BWL, but we can't have everything from life

WizWom · « **Reply #12 on:** August 28, 2006, 02:55:11 PM »

I've gotten the impression that there are a lot of "turf wars" in the modding community. And a lot of "artist's Temperment' people :-) - and I might be one of those, too.

Eh, it's all for fun, right? It's not like we're counting coup, or taking scalps..

SimDing0™ · « **Reply #13 on:** August 28, 2006, 04:10:15 PM »

Quote from: WizWom on August 28, 2006, 02:37:40 PM

OK, yes, SimDing0 made a crappy mod. And don't get me started on the shittiness of mod TP2 coding, I'll rip into Kelsey like a scaling knife into acarp. s'okay, I'm exploring the issue. Like I said, if it's a problem, I'll use a different prefix. Frankly, though, I don't trust you to know WTF you're doing, sorry.

~~Please explore my dick.~~

WizWom · « **Reply #14 on:** August 28, 2006, 04:13:09 PM »

SimDing0™ · « **Reply #15 on:** August 28, 2006, 04:15:45 PM »

No, seriously. If you want to critique my mods, cool. If you want to critique my mods while being an arrogant fuck who overestimates his own self-importance, also cool. If you want to critique my mods on the basis that they don't implement coding techniques which were unavailable at the time of their release, that's not helpful.

WizWom · « **Reply #16 on:** August 28, 2006, 04:26:11 PM »

Heh, I know exactly how important I am - that is, about 1/6,000,000,000 of humanity :-) Just, as it happens, like you.

I recognize how much work went into something like Virtue; but since COPY GLOB is merntioned in the changes log as far back as 1.23, I seriously doubt it wasn't availiable.

SimDing0™ · « **Reply #17 on:** August 28, 2006, 04:29:35 PM »

I'm fully aware of C_E_R. Earlier versions of WeiDU did lack the ability to patch scripts and dialogues the way Virtue requires, however.

In future, I think you'd do well to give me some credit. Contrary to popular opinion, I do know WTF I'm talking about.

the bigg · « **Reply #18 on:** March 14, 2008, 10:29:48 AM »

Two years and still isn't fixed. Can Sim (or somebody with the correct power, if Sim disappeared) update Virtue with the above patch?

Kulyok · « **Reply #19 on:** March 14, 2008, 11:36:56 AM »

Indeed. Two years, and he still hasn't done nothing. (Or, rather, nothing's exactly what he's done). Hmph! Modding is not about sitting there looking sexy, you know. Sometimes you have to fix stuff.

Or angry Kulyok comes. Or cometh, whichever you prefer.

the bigg · « **Reply #20 on:** October 14, 2008, 09:26:50 AM »

Cough.

SimDing0™ · « **Reply #21 on:** October 24, 2008, 05:41:21 AM »

I don't have a house at the moment. I live in a box, okay. (Which does nothing to explain away the rest of the two years, but then...then...fuck you.)

I do have a local version with this fix and a ton of other shit sorted. I'll see what I can do towards getting it out when I have, y'know, the internet.

Kulyok · « **Reply #22 on:** October 24, 2008, 05:47:27 AM »

Wait, you can POST WITHOUT INTERNET CONNECTION? I WANNA!!!

the bigg · « **Reply #23 on:** October 24, 2008, 06:28:52 AM »

sosul · « **Reply #24 on:** October 30, 2008, 12:33:17 AM »

Invariably, it is one again time for me to stick my opinion whether it may be unneeded, unwanted, and/or unwarranted... but that's never stopped me before.

This is all pretty interesting and moderately entertaining like a modders-version of some popular drama series or possibly ANTM... yes, and I shall call it " 'America's' Next Top Modder".

Eh, moving on... there seems to be some sort of "ugly-pretty" or rather just ugly history between certain individuals and possibly between certain groups. Yes, Sim seems to be an interesting fellow who's managed to find a way to be both abrasive and sarcastic at the same time- cheers. Yet there's still something endearing about him that makes me believe he's a good guy at heart though possibly damaged/wounded.

On the other hand, the only thing that appears to be redeeming in WizWorm is his pomposity, which is actually not very redeeming.

Poor the bigg only wants the issue to be resolved and ends up somewhere close to the middle.

Kulyok appears to be the lovable comic relief.

Anyway, clearly Kulyok's statement that "modding is not about sitting there looking sexy" is quite correct, or else, even I'd be able to do it. Unfortunately, I'm quite lacking in the modding department of modding.

It seems as though there's an issue regarding coding which is not updated though possibly not necessarily outdated. Given that, I suppose it may be best for me to hold up on using this mod until it's updated (Keep in mind that I only have half a clue, if even that, regarding what y'all are talking about some modding issue and I just make up the rest).

Of course all of these are a mix of observation and speculation and need not necessarily be accurate.

Well, I hope the issue will one day get resolved and the bigg can finally fully enjoy it (I gotta say you must have a whole lotta patience to wait two-plus years).
I suppose I'll keep Sim in my prayers and hope he is able to acquire a better living arrangement.

News:

Author Topic: I guess this is Virtue's fault... (Read 23932 times)