Author Topic: Beta 239.02  (Read 2724 times)

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1114
Beta 239.02
« on: August 05, 2016, 04:25:49 PM »
Beta location

Full list of changes since 238:
  • GAME_INCLUDES supports SoD.
  • Allow EDIT_SAV_FILE to add wholly new files to SAV files.
  • New NOMOVE keyword for ADD_CRE_ITEM.
  • New TP2 when clause: IF_EXISTS
  • Fix regression in --change-log which produced only the last backup file instead of all of them.
  • GAME_IS et al. do not fail on unrecognised games.
  • Use the correct key value for WBM.
  • Add support for MENU, LUA, TTF, PNG, TOT, TOH key values.
  • Add insert_point to ADD_CRE_EFFECT.
  • region_key and region_script for ALTER_AREA_REGION.
  • Add WITH_TRA and PATCH_WITH_TRA.
  • Fix misspelled parameter in ADD_SPELL_EFFECT.
  • ADD_STORE_ITEM evaluates variables for the flag parameter.
  • If engine.lua exists on EE-type games, engine_name will be used for USER_DIRECTORY.
  • The array construct automatically evaluates variables in the array name ($"%array_name%"())

I've been away for a bit. Is there anything I've forgotten/overlooked that should be in 239?
My Win system is currently down for maintenance, so if someone could verify that the engine.lua thing does what it should, that would be super.
If everything's ok, I'm thinking stable release in a week or two, before the end of August at the very latest.

Offline Angel

  • Planewalker
  • *****
  • Posts: 135
Re: Beta 239.02
« Reply #1 on: August 06, 2016, 03:14:31 AM »
Well, there is one feature request that I never got a reply to:
http://forums.pocketplane.net/index.php/topic,29531.0.html


Offline Argent77

  • Planewalker
  • *****
  • Posts: 179
Re: Beta 239.02
« Reply #2 on: August 06, 2016, 06:17:05 AM »
Are you planning to update ADD_JOURNAL so that it supports EE games patched to v2.0?

Offline Argent77

  • Planewalker
  • *****
  • Posts: 179
Re: Beta 239.02
« Reply #3 on: August 06, 2016, 02:59:03 PM »
I'm getting the following warning(s) when I try to check for SoD:
Quote
WARNING: No rule to identify SODWARNING: No rule to identify SOD
And the component is skipped on both BG:EE with and without SoD installed. (Tested on Windows 7)

The TP2 script:
Code: [Select]
BACKUP ~A7Test/backup~
AUTHOR ~Myself~
VERSION ~1.0~

BEGIN ~Test SoD~
  REQUIRE_PREDICATE (GAME_IS ~bgee~ AND GAME_INCLUDES ~sod~) ~This mod requires BG:SoD to be installed.~
  NO_LOG_RECORD

  PRINT ~SoD detected.~

Regarding engine.lua, USER_DIRECTORY doesn't appear to remove the quotes from the extracted path name. Output on my system is:
Quote
C:\Users\argent77\Documents\"Baldur's Gate - Enhanced Edition"

Offline AL|EN

  • Planewalker
  • *****
  • Posts: 363
  • Gender: Male
Re: Beta 239.02
« Reply #4 on: August 08, 2016, 10:12:19 AM »
False report...delete this.
« Last Edit: August 08, 2016, 10:16:30 AM by AL|EN »
Project Infinity public BETA - mod manager for Infinity Engine games
Modder's Guide to Github - you cannot have progress without committing changes

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1114
Re: Beta 239.02
« Reply #5 on: August 16, 2016, 12:27:14 PM »
Are you planning to update ADD_JOURNAL so that it supports EE games patched to v2.0?
I suppose I should. But I probably won't have time to do it before 239 without postponing 239. The LUA file looks a lot messier to parse.

I'm getting the following warning(s) when I try to check for SoD
Whoops. I had meant to fix that, but turns out I forgot.

Regarding engine.lua, USER_DIRECTORY doesn't appear to remove the quotes from the extracted path name.
Fixed. Thanks.
« Last Edit: August 16, 2016, 12:33:54 PM by Wisp »

Offline Argent77

  • Planewalker
  • *****
  • Posts: 179
Re: Beta 239.02
« Reply #6 on: August 16, 2016, 02:00:41 PM »
Are you planning to update ADD_JOURNAL so that it supports EE games patched to v2.0?
I suppose I should. But I probably won't have time to do it before 239 without postponing 239. The LUA file looks a lot messier to parse.
Feel free to include the ADD_JOURNAL_V2 function from this topic instead.

Offline K4thos

  • Planewalker
  • *****
  • Posts: 110
Re: Beta 239.02
« Reply #7 on: August 17, 2016, 11:59:13 PM »
Quote
I've been away for a bit. Is there anything I've forgotten/overlooked that should be in 239?
I'd like this change to be implemented if it's not a problem. Patch 2.x games worldmap system shows up additional 'Destination Unreachable' / 'Hours' text below the icon but only if the referenced TLK entry for area exist. With sc#addWmpAre generating blank entries in TLK for areas without names it becomes problematic. Not sure if it's related to flags used but some invisible areas without icons receives that additional hardcoded text - no problems if the strref is set to -1 though.
« Last Edit: August 18, 2016, 12:06:10 AM by K4thos »

Offline K4thos

  • Planewalker
  • *****
  • Posts: 110
Re: Beta 239.02
« Reply #8 on: August 20, 2016, 08:03:15 AM »
there seems to be bug in ADD_CRE_EFFECT. Despite readme stating 'special' parameter is supported this test code:
Code: [Select]
LPF ADD_CRE_EFFECT INT_VAR opcode = 232  special = 50 STR_VAR resource = "test" END
didn't set it for some reason.

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1114
Re: Beta 239.02
« Reply #9 on: August 26, 2016, 07:12:24 AM »
there seems to be bug in ADD_CRE_EFFECT. Despite readme stating 'special' parameter is supported this test code:
Code: [Select]
LPF ADD_CRE_EFFECT INT_VAR opcode = 232  special = 50 STR_VAR resource = "test" END
didn't set it for some reason.
Fixed.

Offline Abel

  • Planewalker
  • *****
  • Posts: 5
Re: Beta 239.02
« Reply #10 on: August 28, 2016, 11:42:19 AM »
Thank you, Wisp! I tested the new array construct feature and it works like a charm!
Now, if functions could return arrays, that would be awesome. Macros do the job but functions are easier to code with and to read.

Edit: the new version screws up the USER_DIRECTORY variable by enclosing the folder name in quotes.
« Last Edit: August 28, 2016, 12:20:07 PM by Abel »

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1114
Re: Beta 239.02
« Reply #11 on: August 30, 2016, 11:18:40 AM »
Are you planning to update ADD_JOURNAL so that it supports EE games patched to v2.0?
I suppose I should. But I probably won't have time to do it before 239 without postponing 239. The LUA file looks a lot messier to parse.
Feel free to include the ADD_JOURNAL_V2 function from this topic instead.
Cheers. I think I can swing it so it's used internally by ADD_JOURNAL. I.e., it will not be necessary to change any TP2 code in mods to accommodate the switch to LUA.

Now, if functions could return arrays, that would be awesome. Macros do the job but functions are easier to code with and to read.
I don't think that's feasible with the current implementation of arrays. It's been on my wishlist, as well.

Quote
Edit: the new version screws up the USER_DIRECTORY variable by enclosing the folder name in quotes.
It's been reported and fixed.


Obviously August was not meant to be. I'll finish up a few things and release a new beta. And this time it will be the release candidate. For real.

Offline smeagolheart

  • Planewalker
  • *****
  • Posts: 12
Re: Beta 239.02
« Reply #12 on: September 08, 2016, 06:16:35 PM »
Still close to release soon?   Any updates on weidu?

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1114
Re: Beta 239.02
« Reply #13 on: September 09, 2016, 07:00:17 PM »
I'm still working on the ADD_JOURNAL stuff. I hope to be done soon and it should be the last thing left.

Offline Argent77

  • Planewalker
  • *****
  • Posts: 179
Re: Beta 239.02
« Reply #14 on: September 10, 2016, 04:57:11 AM »
The WeiDU Readme still contains many links to G3 Forums topics in the notation "forums.gibberlings3.net" which doesn't work anymore. They have to be converted into "gibberlings3.net/forums" to work correctly.

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: