Author Topic: Installation feedback suggestion  (Read 1077 times)

Offline CamDawg

  • Infidel
  • Planewalker
  • *****
  • Posts: 859
  • Dreaming of a red Xmas
    • The Gibberlings Three
Installation feedback suggestion
« on: September 21, 2014, 08:38:18 PM »
A minor suggestion, but I'd like to suggest an improvement for the installer's feedback on skipped components that are part of a subcomponent. If at least one of the components has a true predicate, WeiDU presents a subcomponent menu that only offers options for true predicates; failed predicates (and their associated fail string) are suppressed. However, if you were to try this on a game where all predicates fail, e.g. the multi-stronghold block below from BG2 Tweaks on a Tutu install:

Code: [Select]
BEGIN @116001 DESIGNATED 1160 // no restrictions
SUBCOMPONENT @116000 // multi strongholds
REQUIRE_PREDICATE GAME_IS ~soa tob bgt bg2ee~ @25

// junk n stuff

BEGIN @116100 DESIGNATED 1161 // keep class restrictions
SUBCOMPONENT @116000 // multi strongholds
REQUIRE_PREDICATE GAME_IS ~soa tob bgt bg2ee~ @25

// other junk n stuff

then the feedback message you receive during install is:

Code: [Select]
SKIPPING: [No Restrictions (Baldurdash)]
        This component is not available for your game.

SKIPPING: [Keep Class Restrictions]
        This component is not available for your game.

The component names, in this case, are not terribly useful as feedback. It would be nicer in this situation to either see one skip message with the subcomponent name or keep the multiple messages, but add the subcomponent name to the individual component names like WeiDU does on the log. In other words, more useful feedback would either be
Code: [Select]
SKIPPING: [Multiple Strongholds (Baldurdash)]
        This component is not available for your game.
or

Code: [Select]
SKIPPING: [Multiple Strongholds (Baldurdash): No Restrictions (Baldurdash)]
        This component is not available for your game.

SKIPPING: [Multiple Strongholds (Baldurdash): Keep Class Restrictions]
        This component is not available for your game.

First one might be a little more difficult, as the subcomponents may not have matching fail strings on their predicates.

Anyway, a long-winded suggestion for a fairly minor issue. :)
The Gibberlings Three - Home of IE Mods

The BG2 Fixpack - All the fixes of Baldurdash, plus a few hundred more. Now available, with more fixes being added in every release.

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1176
Re: Installation feedback suggestion
« Reply #1 on: September 27, 2014, 09:22:31 AM »
I'll do
Code: [Select]
SKIPPING: [Multiple Strongholds (Baldurdash) -> No Restrictions (Baldurdash)]
        This component is not available for your game.
(Arrow for consistency.)

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: