Author Topic: Bugs and typos for v24  (Read 7085 times)

Offline Lowki

  • Planewalker
  • *****
  • Posts: 3
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #25 on: June 13, 2014, 02:57:08 AM »
Used the GOG version so it should be patched

micbaldur_shs

  • Guest
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #26 on: June 13, 2014, 05:03:13 PM »
Welcome to PPG and hello!

Thank you for reporting! Hmm, I'm not sure if anything is supposed to  be happening(I only see a short script on my end, no dialogue), but an "X appears busy" mantra works in two cases:
- the character is actually leaving(and will disappear in a few seconds if you take the camera off him) - was that the case?
- the game was not patched with the latest official Bioware patch before installing any mods. Are you sure you did patch it?

I'll look into it before updating, certainly, but right now I only see one block where these muggers spawn, no dialogue whatsoever.
Reported this bug in my topic at Spellhold with fix which Lollorian has included to BWP Fixpack.

Tourist in Trouble Encounter: Nightime at Slums (AR0400.ARE) you meet Tourist being robbed by Shady Character and Ogre. Tourist can't talk to you after you kill the robbers due to bug in State Trigger 0 at SLVIC10.DLG.

Changed State Trigger 0 from:

Dead("SlumsMugger2")
Dead("mugger3")

to:

Dead("SlumsMugger2")
Dead("SlumsMugger4")

Brotkopf

  • Guest
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #27 on: July 29, 2014, 08:08:26 AM »
hey, i have another bug here, in the Copper Corone, when i tried to talk to suna seni or unger the game freezes. i am playing the EE and also have the banter pack and german text mod installed. uninstall and reinstall of the mod dosnt solve the issue. any advice or just deinstall of UB and playing without it ?

mfg

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #28 on: July 29, 2014, 08:36:58 AM »
I don't think Unfinished business is adapted to foreign languages on EE yet. Currently Wisp is working on a new Weidu version with some cool functions. I'd like to adapt them for UB translations and make them available for BG2EE as soon as I see some big/popular mods using these method and succeeding(i.e. no flood of bug reports in the first weeks).

You can enjoy UB in English on EE, I understand.

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #29 on: August 05, 2014, 12:47:52 AM »
I should use Wisp's HANDLE_CHARSETS as soon as I see other popular mods using it without any game-breaking bug reports(BG2Tweaks, I'm looking at you!).

Also, a very useful report from Almateria:
 - In Sarevok's Remorse component, the slilmat's/wilmat's evil character/low rep dialogue indicates that you get Yoshimo's belongings from the cleric. However, you really don't, all you get is the 200000 XP.
(I probably should edit the dialogue, though I don't feel comfortable doing it. Hmm, what if the line is from the original game, gasp? Ah, anyway, will check. I can always SET_STRING, because I'm THAT evil).

Offline Almateria

  • Planewalker
  • *****
  • Posts: 69
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #30 on: August 05, 2014, 04:08:50 AM »
It's not much of a change, just change this:
Code: [Select]
IF ~~ MERIT
SAY @95 IF ~~ GOTO HERE
END

IF ~~ PERCEIVE
SAY @96 IF ~~ GOTO HERE
END
to this:
Code: [Select]
IF ~~ MERIT
SAY @95 IF ~Global("U!SYoshimo","GLOBAL",1) ~ DO
~GiveItemCreate("U!SBOOK1",LastTalkedToBy,1,1,0)
   GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
IF ~OR(2)
Global("U!SYoshimo","GLOBAL",0)
Global("U!SYoshimo","GLOBAL",2)~ DO
~GiveItemCreate("U!SBOOK2",LastTalkedToBy,1,1,0)
GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
IF ~Global("U!SYoshimo","GLOBAL",3)~ DO
~GiveItemCreate("U!SBOOK3",LastTalkedToBy,1,1,0)
GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
END

IF ~~ PERCEIVE
SAY @96 IF ~Global("U!SYoshimo","GLOBAL",1) ~ DO
~GiveItemCreate("U!SBOOK1",LastTalkedToBy,1,1,0)
   GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
IF ~OR(2)
Global("U!SYoshimo","GLOBAL",0)
Global("U!SYoshimo","GLOBAL",2)~ DO
~GiveItemCreate("U!SBOOK2",LastTalkedToBy,1,1,0)
GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
IF ~Global("U!SYoshimo","GLOBAL",3)~ DO
~GiveItemCreate("U!SBOOK3",LastTalkedToBy,1,1,0)
GiveItemCreate("U!SWAKIZ",LastTalkedToBy,1,1,0)~
+ HERE
END

in u!sare1.d

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #31 on: August 05, 2014, 04:33:34 AM »
Yay? Yay! Cool. Basically, change MERIT to SEEK, right? Thank you! With this terrible heat, my brain's nearly stopped working(going out for lunch was a bad, bad idea!)

Offline Almateria

  • Planewalker
  • *****
  • Posts: 69
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #32 on: August 05, 2014, 04:40:55 AM »
Yes, except keep the MERIT string, obviously. And do the same for PERCEIVE.

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #33 on: August 12, 2014, 05:46:33 AM »
Need an EE-sized portrait for Minsc after Boo's been kidnapped: http://forums.pocketplane.net/index.php?topic=29207

EDIT: Huge thanks to Isandir for the portraits, and to Sed for letting me know(and to Cahir for trying it first!):
http://forums.pocketplane.net/index.php/topic,29207.msg335495.html#msg335495

Offline Cahir

  • Planewalker
  • *****
  • Posts: 95
  • Gender: Male
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #34 on: August 12, 2014, 07:24:45 AM »
Kulyok, I managed to re-size these portraits, but if you need better quality, some wizard needs to do it, I'm afraid.


Anyway, I sent it to your e-mail box ;)

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #35 on: August 12, 2014, 07:48:43 AM »
Thank you! Oh, this was fast! Got the files and replied.

(waiting for some of the big famous cool mods to be updated with Wisp's newest tra functions, so I could make UB work fine with EE tra files, too. Then there'll be an update!)

Offline Almateria

  • Planewalker
  • *****
  • Posts: 69
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #36 on: August 12, 2014, 01:09:24 PM »
Is ARP big/famous/cool enough? :P Because an update is stuck in the release cycle, but it's gonna utilize these functions.

Offline Almateria

  • Planewalker
  • *****
  • Posts: 69
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #37 on: August 12, 2014, 01:45:31 PM »
Also, I sent you Polish translation files that Cahir managed to screw up.

Offline Cahir

  • Planewalker
  • *****
  • Posts: 95
  • Gender: Male
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #38 on: August 12, 2014, 02:32:42 PM »
Alma, knowing your unusual sense of humour I ask politely, what do you mean by saying that I managed to  "screw something up"?

Offline Almateria

  • Planewalker
  • *****
  • Posts: 69
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #39 on: August 12, 2014, 03:35:13 PM »
Only the EE setup was translated, genius.

e: Also, I don't have "an unusual sense of humor", thank you. Unlike you, I'm not willing to bring the Bad Site into this conversation; only your mistakes.
« Last Edit: August 12, 2014, 03:49:11 PM by Almateria »

Offline Cahir

  • Planewalker
  • *****
  • Posts: 95
  • Gender: Male
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #40 on: August 12, 2014, 03:57:58 PM »
Alma, jumping with "screwing up" thing without telling what's the problem seems to be a bit rude, don't you think?

I really did forget about non EE-part, apparently, but you just should let me know via PM and I would send it to Kulyok with no time.

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #41 on: August 13, 2014, 12:49:08 AM »
Thank you both very much for helping me! :) I'll happily download ARP when it's done(but I'm not as brave, I fear - I'd rather see a few more mods updated first, though I don't know - if ARP keeps working fine and there're no translation-related errors, the game's in the bag).

Offline Isaya

  • Planewalker
  • *****
  • Posts: 47
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #42 on: August 13, 2014, 03:52:40 AM »
(waiting for some of the big famous cool mods to be updated with Wisp's newest tra functions, so I could make UB work fine with EE tra files, too. Then there'll be an update!)
I don't know if Sarah qualifies as cool or famous but I uploaded a patch to include the French translation that uses HANDLE_CHARSETS, taking inspiration of what Wisp demonstrated in Edwin Romance.
Since UB only uses tra files and even the EE specific setup file is encoded in CP-something, it is a simple matter of converting all tra files, which is the easiest thing with HANDLE_CHARSETS (no exception to handle). It would probably come down to adding this in ALWAYS:
Code: [Select]
  // Code borrowed from Edwin Romance V206, using the new HANDLE_CHARSETS function
  INCLUDE ~%MOD_FOLDER%/handle_charsets.tpa~

  /*
   * An array of the TRA files which should not be converted.
   * The .tra file extension is implied and should not be explicitly added.
   * The array can be named anything.
   */
  // For UB, ubsetup.tra contains in game texts as well as installation texts
  // and need to be converted, so no exception
  ACTION_DEFINE_ARRAY fl#noconvert BEGIN END

  /*
   * An array of the TRA files which should be reloaded after being converted.
   * These are typically TRA files loaded by LANGUAGE.
   * The .tra file extension is implied and should not be explicitly added.
   * The array can be named anything.
   */
  // Since ubsetup-ee.tra is not stated in LANGUAGE, it doesn't have to be reloaded
  // ubsetup is enough
  ACTION_DEFINE_ARRAY fl#reload BEGIN ubsetup END

  /*
   * If the game is of an EE-type, this function will convert all
   * specified or all but the specified TRA files into UTF-8 and
   * optionally reload some of the TRA files it converted (typically
   * the same TRA files as loaded by LANGUAGE).
   *
   * This function requires that %infer_charset% is set to 1 OR it
   * requires a valid declaration for %charset_table%.
   * It additionally requires that %tra_path% is specified such that
   * %tra_path%/%LANGUAGE% is a valid directory containing TRA files.
   * Furthermore, if iconv.exe is not located in %tra_path%/iconv, you must
   * specify the location of iconv.exe with the variable %iconv_path%.
   *
   * You can EITHER specify the array %noconvert_array% OR the array
   * %convert_array%. The former should contain all those TRA files
   * which should not be converted and the latter should contain all
   * those TRA files which should be converted. You can optionally
   * specify %reload_array%, which should contain all those TRA files
   * that should be reloaded through LOAD_TRA after being converted.
   * Any TRA file already loaded before being converted would still
   * contain unconverted text, unless reloaded.
   */
  LAF HANDLE_CHARSETS
    INT_VAR
      infer_charset = 1
    STR_VAR
      tra_path = EVAL ~%MOD_FOLDER%/tra~
      // charset_table = fl#charsets // Included for illustrative purposes.
      noconvert_array = fl#noconvert
      reload_array = fl#reload
  END
and adding:
  • handle_charsets.tpa in the ub directory (you can copy it from Edwin Romance)
  • iconv directory (from Edwin Romance too) in ub/tra

I have one thing to report after looking at the tp2. There is something strange about ubsetup-ee.tra. It's not referenced in the tp2 and there is no INCLUDE in the tp2 to justify that it could be used somewhere else. It looks like this file is not used at all, hence the item descriptions added to BG2EE are still using the unnecessary "Unsable by" in contradiction with the fact that BG2EE adds them automatically (and without forgetting any case, contrary to human brain).
For instance, prior to updating WAND14 in component @27, I believe you should add this at the beginning of the component (as described in Camdawg tutorial)
Code: [Select]
ACTION_IF GAME_IS BG2EE THEN BEGIN
  LOAD_TRA ~ub/tra/%LANGUAGE%/ubsetup-ee.tra~
END
for each component where an item using a description present in ubsetup-ee.tra is updated/added. There are a few more than 10 cases like this, most of them are in component @73.

Offline Wisp

  • Planewalker
  • *****
  • Posts: 890
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #43 on: August 14, 2014, 10:32:19 AM »
Small note: I used my prefix in ER because you are supposed to define your own array and table names (the design of HANDLE_CHARSETS explicitly allows for this). Theŕe is also no need to define or pass the noconvert array unless it's non-empty.

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #44 on: August 14, 2014, 12:29:05 PM »
Ah, oops. Completely forgot the proper tob lines for that file. :) Thank you!

So I should use o#modname instead of fl#, huh? Will remember that.

Offline Erg

  • Planewalker
  • *****
  • Posts: 31
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #45 on: August 15, 2014, 09:56:51 AM »
In BGII:EE Eleanya casts spell with a male voice (reported by kaguana on the EE Forum).

This is most likely due to the fact that her "SEX" attribute (at offset 0x237 in the CRE file) is set to "UNKNOWN" instead of "FEMALE".

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #46 on: August 15, 2014, 10:03:44 AM »
Will fix, thank you very much for taking the time to report this! I try to visit BGEE forums once in a while, but it just doesn't happen as often as I like.

Offline Ilot

  • Planewalker
  • *****
  • Posts: 21
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #47 on: September 23, 2014, 08:15:59 AM »
Hi Kulyok

I'm updating Unfinished Business in italian language (Murder of Acton Balthis quest) can I send you the italian.tra when I finished it? (and if yes, where I send them?)

Meanwhile testing in italian language "Murder of Acton Balthis quest" I was unable to complete the quest because Janos not spawn in AR0506.ARE and, I think, because the jurnal not update when I set free Haer'Dalis from the prison and Haer'Dalis say: "I have a thought, an idea both brilliant and plain...." .

Thanks
« Last Edit: September 23, 2014, 08:21:04 AM by Ilot »

Offline jastey

  • Planewalker
  • *****
  • Posts: 1173
  • Gender: Female
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #48 on: September 24, 2014, 04:31:37 PM »
Hi,
how is the status of the German translation, is any new lines needed? I aplogize for being completely not up-to-date and not feeling like reading through the whole forum..

One plea: If the German version is finished, would it be possible to make a new version with BGII:EE formatted tra files, like you did for Xan BG1 friendship? We would love to play UB in German, too. :)

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6235
  • Gender: Female
  • The perfect moment is now.
Re: REPORT ALL ISSUES, BUGS AND TYPOS FOR V24 HERE AND ONLY HERE
« Reply #49 on: September 25, 2014, 10:15:21 AM »
I'm not much up-to-date, either! I'd like to make the thingy for UB:EE, too: I just hesitate because with Xan BG1, it wasn't me, it was BG1 NPC team's gracious help, Isaya in particular. :)