[BUG?] Compiler errors when adding new action to action.ids

[Argent77]

Don't know if this is a bug or a mistake on my side, but when I add the alternative syntax of action 293 to action.ids,

Code: [Select]

APPEND ~action.ids~ ~293 StartDialogOverride(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)~
UNLESS ~293 StartDialogOverride(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)~
then WeiDU's compiler triggers an error message whenever I use the first syntax version in my scripts, although they compile correctly and work in-game.

These are the relevant passages in of my .DEBUG file:

Appending to files ...
[./override/ACTION.IDS] loaded, 13104 bytes
Appending [293 StartDialogOverride(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)...] to [action.ids] because it does NOT contain [293 StartDialogOverride(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)]
override/action.ids copied to DjinniCompanion/backup/0/action.ids, 13104 bytes
Appended text to [action.ids]

[snip]

Compiling 1 script ...
[DjinniCompanion/scripts/A7afqtlk.baf] loaded, 17733 bytes

[tb#compile_patches/DjinniCompanion/scripts/A7afqtlk.baf] PARSE ERROR at line 149 column 8-45
Near Text: )
    Not enough arguments to [StartDialogOverride]. Recovering.

[tb#compile_patches/DjinniCompanion/scripts/A7afqtlk.baf] PARSE ERROR at line 222 column 8-45
Near Text: )
    Not enough arguments to [StartDialogOverride]. Recovering.

The scripting action in question is:

Code: [Select]

    StartDialogOverride("A7AFQB", Player1)

PS: I'm using WeiDU 231.

[devSin]

Going by memory...

WeiDU uses the last match in associating symbols. If you need an alternate for the same ID but with different arguments, you need a different name (I think that will let it work when compiling).

Be aware that when decompiling that ID, it will revert always to the last symbol given in the IDS (so any code, after your change, will decompile always to S:,O:,I:,I:,I:).

Near Infinity will use the first symbol IIRC, to make matters more confusing (it will always drop your extra arguments when decompiling).

Note that when WeiDU says it has recovered, it fills in the remaining arguments with defaults. In this case, your script code was saved as StartDialogOverride("A7AFQB",Player1,0,0,0). The warnings can be safely ignored (you're only going to get into trouble if you need the extra arguments for something).

[Argent77]

Hmm, that behaviour makes it too unreliable to use. If, for some reason, the signature has already been added to action.ids BEFORE the shorter syntax, the compiler will simply cut off all additional parameters from the longer scripting action and doesn't work as expected in-game.

I guess I have to rename it to something else for the moment, like StartDialogOverrideItem or so.

NB: There are at least two more actions which might trigger the same behaviour (ForceSpellRES and ForceSpellPointRES).

[the bigg]

The alternative synthax must use a different name for it to work. In particular, SpellRES and friends work because the action name is different between different forms.

Code: [Select]

APPEND ~action.ids~ ~293 StartDialogOverrideAsItem(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)~
UNLESS ~293 StartDialogOverrideAsItem(S:DialogFile*,O:Target*,I:Unused,I:Unused,I:ConverseAsItem)~
<...>
    StartDialogOverride("A7AFQB", Player1)
    StartDialogOverrideAsItem("A7AFQB", Player1, 0, 0, 1)