Author Topic: GROUP order  (Read 8161 times)

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #25 on: October 23, 2010, 06:07:05 PM »
That's what you get for requesting translations.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #26 on: October 23, 2010, 06:29:20 PM »
Multiple groups still work properly. However, since GROUP constraints act as REQUIRE_PREDICATE, it ends up working like REQUIRE_PREDICATE (GROUP_ENABLED ~BG2 NPCs~ OR GROUP_ENABLED ~BG1 NPCs~) AND GAME_IS ~bg2 tob~ AND GAME_IS ~tutu tutu_totsc bgt~.

GROUP constraints are documented in the GROUP tutorial.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Miloch

  • Barbarian
  • Planewalker
  • *****
  • Posts: 1030
  • Gender: Male
Re: GROUP order
« Reply #27 on: October 23, 2010, 06:57:19 PM »
However, since GROUP constraints act as REQUIRE_PREDICATE, it ends up working like REQUIRE_PREDICATE (GROUP_ENABLED ~BG2 NPCs~ OR GROUP_ENABLED ~BG1 NPCs~) AND GAME_IS ~bg2 tob~ AND GAME_IS ~tutu tutu_totsc bgt~.
Well that is fairly counterproductive, because the game will never be *both* BG2 and Tutu. Should be a disjunction of two conjunctions, not vice-versa:
(GROUP_ENABLED ~BG2 NPCs~ AND GAME_IS ~bg2 tob~) OR (GROUP_ENABLED ~BG1 NPCs~ AND GAME_IS ~tutu tutu_totsc bgt~)

Now, I could remove the constraints from this component, based on the assumption there will always be an Edwin present regardless of platform. But my request was to look for all constraints for the GROUP and treat them as a conjunction (primarily for mod-added NPCs). By that, I meant the selected group - the BG2 NPC group is autoskipped here, so it shouldn't be looking at the constraints for it. Doesn't make much sense to remove the constraints from all GROUPs either. Any chance of restoring the v221 beta behaviour, only with the "conjunctive constraints" added (sounds a bit like "conjugal visits" eh)?

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #28 on: October 23, 2010, 07:38:35 PM »
(GROUP_ENABLED ~BG2 NPCs~ AND GAME_IS ~bg2 tob~) OR (GROUP_ENABLED ~BG1 NPCs~ AND GAME_IS ~tutu tutu_totsc bgt~)
This will be the behavior in 222, then.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Miloch

  • Barbarian
  • Planewalker
  • *****
  • Posts: 1030
  • Gender: Male
Re: GROUP order
« Reply #29 on: October 23, 2010, 07:59:57 PM »
Hey, if you've already done one ninja-fix and re-upload, why not another? :D (it's not like anyone else is using this feature, as yet)

Um, if not, is there a way I can fix locally short of ungrouping such components?

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #30 on: October 23, 2010, 08:06:53 PM »
No stealthy fix because this one is anything but an one-liner.

I think ungrouping those is the only available solution.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #31 on: October 24, 2010, 09:25:57 AM »
Does the newly uploaded beta work satisfactorily for you?
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Miloch

  • Barbarian
  • Planewalker
  • *****
  • Posts: 1030
  • Gender: Male
Re: GROUP order
« Reply #32 on: October 24, 2010, 11:59:49 AM »
Yes, it appears to.

As long as you're in there, there appears to be a slight glitch with the sc#addWmpAre function, in that if you set inclSv to 1, it will fail if no saves are present. Though I didn't write this code, I'm thinking it should be fixable by putting some actual regexp in GET_DIRECTORY_ARRAY? So instead of:
GET_DIRECTORY_ARRAY save save ~~

GET_DIRECTORY_ARRAY save save ~.+~

If that doesn't work, maybe we need some sort of DIRECTORY_EXISTS regexp parameter.

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #33 on: October 24, 2010, 01:51:34 PM »
According to the source code, it fails because there is no save directory; an empty regexp is translated to "everything but . and ..", and an empty save/ directory simply results in an empty array being saved. The simplest solution would be to use MKDIR save before running sc#addwmpare; the 222 version of sc#addwmpare will execute MKDIR save on its own (unless you can think of a case where it'd be beneficial to have GET_FILE|DIRECTORY_ARRAY, *_BASH_EACH and the like silently skipping over missing directories).
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Miloch

  • Barbarian
  • Planewalker
  • *****
  • Posts: 1030
  • Gender: Male
Re: GROUP order
« Reply #34 on: October 25, 2010, 02:15:12 AM »
The simplest solution would be to use MKDIR save before running sc#addwmpare; the 222 version of sc#addwmpare will execute MKDIR save on its own (unless you can think of a case where it'd be beneficial to have GET_FILE|DIRECTORY_ARRAY, *_BASH_EACH and the like silently skipping over missing directories).
Ok, whatever works. I don't use it or know of it being used outside of messing with saved games.

MKDIR I guess does nothing if the folder already exists?

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: GROUP order
« Reply #35 on: October 25, 2010, 05:21:31 AM »
Yes.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: