Author Topic: Wish List  (Read 6264 times)

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Wish List
« on: May 05, 2008, 11:21:42 PM »
Okay, just about done with some major mods, and used a whole hell of a lot of WeiDU features, and I must say, this is seriously one powerful tool for modding these games.  Major kudos.  There's very little I couldn't do.  But there were a couple of blocks, and since this forum says it's meant for feature requests, thought I'd throw them out there.  And hey, maybe somebody will point out there -is- a way to do these things that I just missed.

Dunno if these things have been asked for before, btw, and sorry if I'm beating any dead horses.

WISH LIST:

1.  REPLACE_TRANS_TRIGGER, with the same functionality and syntax as REPLACE_TRANS_ACTION.  This would seriously rock.  The lack of such a function is the only thing really preventing me from making my mods totally non-destructive of existing content (ALTER_TRANS being the only alternative I know of to modify a single response trigger, and it is destructive).

2.  A way to totally remove a JOURNAL or REPLY strref, which thebigg already said he was going to implement - yay :)

3.  When using the various weidu --tlkcmp-from/tlkcmp-to options on the dialog.tlk file, add some sort of switch to handle when either of the dialog.tlk files contain non-standard carriage return handling, like CRLF.  An example where this happens and has caused me tremendous grief is the Planescape Torment dialog file... try doing --traify-tlk on that and then pull it up in ConTEXT (all carriage returns are doubled), or pull it up in Notepad, save it, and reload it (most carriage returns deleted altogether), and you'll see what I mean.  If it could be made so the comparison functions would -not- count a difference in carriage-return/line feeds as a significant difference, that would solve all the problems I encountered.

4.  This probably is due to similar issues as #3 - when I ran "APPEND_FILE" on the PS:T file "quests.ini" to add something to the end of it, all the blank lines in my resulting file were gone, oddly including the blank lines -before- the point where I did my append.

5.  I don't know if this matters -at all-, but I couldn't help noticing that, when you do STRING_SET, it makes the type of each entry in the dialog.tlk file a "7", which IESDP says is only meant for BG2.  I haven't noticed it causing me any problems yet, but maybe there should be some way to tell STRING_SET what type to set the STRING as, or perhaps not to change whatever it originally is.  As I said, though, it's not caused me any problems yet, so this is a really low priority request.  Maybe someone else can think of an issue it -could- cause though.

6.  There is no 6.  After pummeling this tool hard for several weeks, those are really the only significant issues I found.  Not bad at all, gents :)

Qwinn
« Last Edit: May 05, 2008, 11:26:13 PM by Qwinn »

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #1 on: May 06, 2008, 07:17:17 AM »
1. Ok. Somebody else will have to differentiate between REPLACE_TRANS_TRIGGER and REPLACE_TRIGGER_TEXT, or why REPLACE_STATE_TRIGGER and REPLACE_TRANS_TRIGGER work in different ways, though.
EDIT: actually, REPLACE_TRIGGER_TEXT should already do what you want (regexp substitution) on both Trans and State triggers. Is this enough, or is your regexp also matched by a State Trigger where it shouldn't?
2. Ok, already answered as you said.
3. 4. CR/LF handling is a very delicate issue - different text editors fuck them up in different ways and different people want different behaviours and different games use different behaviours, making it atrouciously hard to do properly. Can you give me proper numerical/textual examples?
5. Currently WeiDU always uses '7' as a flag whenever it creates or edits a string, aye. Does it actually cause any problem and, if so, which value would you prefer?
« Last Edit: May 06, 2008, 07:23:21 AM by the bigg »
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline devSin

  • Planewalker
  • *****
  • Posts: 1632
  • Gender: Male
Re: Wish List
« Reply #2 on: May 06, 2008, 10:05:22 AM »
The string type is a bitfield. 7 is just 3(Bit0+Bit1)+Bit2, and all engines understand Bit0 and Bit1, so nothing bad is happening.

There's an open case around here somewhere where I tried to get bigg to do the flags correctly (empty string = 0; empty string w/ audio = 2(Bit1); string = 3(Bit0+Bit1); string with tokens (BG2-only) = 7(Bit0+Bit1+Bit2)), but no juice.
« Last Edit: May 06, 2008, 10:08:52 AM by devSin »

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #3 on: May 06, 2008, 10:06:00 AM »
There's an open case around here somewhere where I tried to get bigg to do the flags correctly, but no juice.
Link PLZ.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #4 on: May 06, 2008, 10:53:20 AM »
Quote
actually, REPLACE_TRIGGER_TEXT should already do what you want (regexp substitution) on both Trans and State triggers. Is this enough, or is your regexp also matched by a State Trigger where it shouldn't?

The problem with REPLACE_TRIGGER_TEXT is that you can't make it work for the triggers of a specific state, it's every trigger in the file or nothing.  The text I'm replacing may be perfectly valid in many, even most states, and I may just want to change it in a specific one.  That's why a syntax and functionality like REPLACE_TRANS_ACTION, where you can specific BEGIN [statelist] END BEGIN [transition] END ~TextToBeReplaced~ ~NewText~ would rock.

Another way to look at it is, whatever possessed someone to create REPLACE_TRANS_ACTION when REPLACE_ACTION_TEXT was already available, same reasoning here :)

Quote
3. 4. CR/LF handling is a very delicate issue - different text editors fuck them up in different ways and different people want different behaviours and different games use different behaviours, making it atrouciously hard to do properly. Can you give me proper numerical/textual examples?

I can believe it'd be a bitch.  Do you have a copy of PS:T?  If so, I think the best and easiest demonstration would be for you to just do an APPEND (anything) onto the quests.ini file, and watch every blank line disappear in the result.  Even if the --tlkcmp functions can never get this problem resolved, I think at least the APPEND functions shouldn't change anything in the original file.  If the --tlkcmp functions can never have this issue resolved, it's alright, I've already done my penance dealing with it, I'll just have to do all my editing of this stuff in MS Word, it's the only one I have that doesn't screw it up royally.

Quote
5. Currently WeiDU always uses '7' as a flag whenever it creates or edits a string, aye. Does it actually cause any problem and, if so, which value would you prefer?

Not causing any problems at all, and I'm perfectly happy with devSin's reassurances on this, so strike that from the list.

Qwinn

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #5 on: May 06, 2008, 11:05:11 AM »
1. OK then. The various REPLACE_* actions all behave differently now anyway (all the file vs. state/trans list, regex vs. destructive replace), so having more inconsistencies won't harm.

3&4. I have PST, yeah. I'll check quest.ini, and the tlkcmp when/if I feel like doing so to prepare for the Great PST Modding Special Resurrection of 2012  :)
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #6 on: May 06, 2008, 11:11:14 AM »
Link PLZ.
Wow! One-year-and-an-half old, with a gratuitous goatse.cx mention!

(workroom only, sorry  :) )
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline devSin

  • Planewalker
  • *****
  • Posts: 1632
  • Gender: Male
Re: Wish List
« Reply #7 on: May 06, 2008, 11:14:05 AM »
Yeah, I didn't notice that till after I bumped it.

Both sad that's it's over a year old and that it was still on the first forum page (I was all ready to search for it, but it was right there). :-)

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #8 on: May 06, 2008, 11:18:39 AM »
Both sad that's it's over a year old and that it was still on the first forum page (I was all ready to search for it, but it was right there). :-)
The sad part is that I checked to see if hello.jpg was still available, and it wasn't  :(
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #9 on: May 06, 2008, 12:25:52 PM »
"3&4. I have PST, yeah. I'll check quest.ini, and the tlkcmp when/if I feel like doing so to prepare for the Great PST Modding Special Resurrection of 2012  Smiley"

Actually, it's more like the Great PST Modding Special Resurrection of May 31 2008 (approximately).  :)  I'm about 98% done with a full WeiDU Fixpack that includes just about every fix done in Platter's Fixpack 1.37, Restoration Pack and SKARDAVNELNATE's "All Inclusive Fixpack", plus a whole bunch of my own.... AND a WeiDU PS:T Unfinished Business with a whole ton of restored quests and other content, AND my own WeiDU Tweak Pack with some cool never-before-seen material.  Not to mention over 600 spelling and grammar fixes to the dialog file.

All 3 will be hosted at Spellhold Studios.  I'm planning release around the end of this month (hoping to start my playtest in the next couple days.)

So, if there's no modding after I release all -that-, it won't be because there wasn't any WeiDU fixpacks, UB, etc. to build on anymore ;)

Qwinn

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #10 on: May 06, 2008, 01:40:58 PM »
Actually, it's more like the Great PST Modding Special Resurrection of May 31 2008 (approximately).  :)
Nah, I was talking about the fact that, out of the blue, three mods + a total conversion for IWD1 appeared in a month... and then everybody properly forgot about them.

Quote
I'm about 98% done with a full WeiDU Fixpack that includes just about every fix done in Platter's Fixpack 1.37, Restoration Pack and SKARDAVNELNATE's "All Inclusive Fixpack", plus a whole bunch of my own.... AND a WeiDU PS:T Unfinished Business with a whole ton of restored quests and other content, AND my own WeiDU Tweak Pack with some cool never-before-seen material.  Not to mention over 600 spelling and grammar fixes to the dialog file.
I hope you won't do this as a giant component a-la-IA... otherwise I'd be forced to flame you as well.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #11 on: May 06, 2008, 04:23:18 PM »
Quote
Nah, I was talking about the fact that, out of the blue, three mods + a total conversion for IWD1 appeared in a month... and then everybody properly forgot about them.

Heh.  Thanks for the encouragement.  Did you mean "promptly", or did you really mean "properly"?  Cause since you're suggesting my mods and theirs will share the same fate, I'd like to know -why- you think they should "properly" be forgotten.

I never heard about those iWD mods, btw... where are they hosted?

Quote
I hope you won't do this as a giant component a-la-IA... otherwise I'd be forced to flame you as well.

IA?

Qwinn

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #12 on: May 06, 2008, 04:32:12 PM »
Heh.  Thanks for the encouragement.  Did you mean "promptly", or did you really mean "properly"?  Cause since you're suggesting my mods and theirs will share the same fate, I'd like to know -why- you think they should "properly" be forgotten.
Yeah, I meant promptly.

Quote
I never heard about those iWD mods, btw... where are they hosted?
IWD1NPC here, IWD1 Item Upgrade and IWD1 Unfinished Business at G3, IWD1 to BG2 engine at G3, and a revamp of IWD1TweakPack at G3.

Quote
IA?
Best not to touch the subject, even with a ten foot pole.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #13 on: May 06, 2008, 04:39:29 PM »
Quote
IWD1NPC here, IWD1 Item Upgrade and IWD1 Unfinished Business at G3, IWD1 to BG2 engine at G3, and a revamp of IWD1TweakPack at G3.

Oh - you mean like -last- month.  I wouldn't say they're forgotten... I definitely plan to play through with those - and I probably wouldn't replay IWD1 if -not- for those - but I just wanted to finish up my current projects before doing so.  I'd probably be playing them now if I hadn't started this PS:T project.  I suspect lots of folks are in the same boat.  And I'm sure lots of people who do eventually try my mods won't get around to it till a few months after release. - if more than a handful drop everything immediately to try them out, I'd consider that a pretty big success :)

Qwinn

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #14 on: May 07, 2008, 12:57:13 AM »
Okay, here's another low priority wish (and maybe there's a way to do it I can't find).

I've run into a situation where the official PST patch 1.1 did something rather badly, and in fixing one bug created another.  I want to get -rid- of 2 files that it put in the override, and redo their fix in a different way that doesn't cause other problems.  Is there a way to use WeiDU to delete a file from the override directory so that it uses what was in the biffs?  If not, I'll just put the old versions in my /copy directory and overwrite them, but hoping there's a cleaner way to do it... I prefer to keep my /override and /copy directories as uncluttered as I can.  Again, low priority, just a nice to have.

Qwinn

Offline devSin

  • Planewalker
  • *****
  • Posts: 1632
  • Gender: Male
Re: Wish List
« Reply #15 on: May 07, 2008, 01:07:22 AM »
Nope. You can re-patch their patch or copy the 1.0 files and do your own patches.

There was call for ignoring override files some time ago, but it's not generally a good idea and is pretty contrary to the whole purpose of WeiDU, so don't expect to ever see it.

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #16 on: May 07, 2008, 03:37:33 AM »
Alright, fair enough.  No worries.

Believe me, if all I get out of my wish list is #1 and #2, I'll still be delighted :)

Oh, PS, the three mods will not be all one component, no, heh.  The Fixpack will be a single component, but the UB will be around 9 components and the Tweak Pack is currently at 2 and hopefully at least 5 by release.

Qwinn
« Last Edit: May 07, 2008, 03:42:31 AM by Qwinn »

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #17 on: May 07, 2008, 07:26:24 AM »
I can't replicate #4 (quests.ini losing blank lines) with either APPEND or APPEND_FILE. Can you zip your quests.ini up and email it to thebigg@spellholdstudios.net?
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #18 on: May 07, 2008, 07:38:08 PM »
Sorry, sorry, sorry, really sorry, I wasn't specific enough.  It's APPEND_OUTER that did it, not just APPEND.

Here's exactly what I did.  All the COPY is doing is counting the number of existing quests in the file and updating the questcount in the first line. 

The file still has all of it's blank lines after the BUT_ONLY_IF_IT_CHANGES.  It loses them during the APPEND_OUTER. 

Code: [Select]
COPY ~quests.ini~ ~quests.ini~
  COUNT_REGEXP_INSTANCES CASE_INSENSITIVE ~descAssigned=~ "Quest1"
  SET "NewTotal" = "Quest1" + 2
  SET "Quest2" = "Quest1" + 1
  REPLACE_TEXTUALLY
    ~questcount=%Quest1%~ ~questcount=%NewTotal%~
 BUT_ONLY_IF_IT_CHANGES

APPEND_OUTER ~quests.ini~
~[%Quest1%]
title=64151
descAssigned=64940
descCompleted=64941
assignedChecks=1
aVar1=Sheryl_Quest
aValue1=3
aCondition1=EQ
completeChecks=1
cVar1=Sheryl_Quest
cValue1=4
cCondition1=EQ
[%Quest2%]
title=64943
descAssigned=64944
descCompleted=64945
assignedChecks=1
aVar1=Ulthera_Quest
aValue1=3
aCondition1=EQ
completeChecks=1
cVar1=Ulthera_Quest
cValue1=4
cCondition1=EQ~

Again, sorry for wasting your time looking at other versions of APPEND.

Let me know if you still can't replicate it, and I'll send you the quests.ini I get after I run this bit on it.

Qwinn
« Last Edit: May 07, 2008, 07:42:40 PM by Qwinn »

Offline Nythrun

  • Planewalker
  • *****
  • Posts: 89
  • Gender: Female
Re: Wish List
« Reply #19 on: May 08, 2008, 01:22:23 AM »
On Windows, APPEND_OUTER is always adding a CRLF before any appended text (such that APPEND_OUTER any.file ~~ is still adding two bytes of trash).

It looks, however, like it's also taking it upon itself to replace every instance of CRLFCRLF with CRLF.

Some form of the following (with "proper" linefeeding in the inlined file) for a tide-me-over?
Code: [Select]
<<<<<<<<inlinedfilesarecool/ini.update

[%Quest1%]
title=64151
descAssigned=64940
descCompleted=64941
assignedChecks=1
aVar1=Sheryl_Quest
aValue1=3
aCondition1=EQ
completeChecks=1
cVar1=Sheryl_Quest
cValue1=4
cCondition1=EQ

[%Quest2%]
title=64943
descAssigned=64944
descCompleted=64945
assignedChecks=1
aVar1=Ulthera_Quest
aValue1=3
aCondition1=EQ
completeChecks=1
cVar1=Ulthera_Quest
cValue1=4
cCondition1=EQ
>>>>>>>>
COPY_EXISTING quests.ini quests.ini
  COUNT_REGEXP_INSTANCES ~^\[[0-9]+\]~ Quest1
  REPLACE_EVALUATE ~questcount=%Quest1%~ BEGIN
    SET NewTotal = Quest1 + 2
  END              ~questcount=%NewTotal%~
  SET Quest2 = Quest1 + 1
  APPEND_FILE_EVALUATE ~inlinedfilesarecool/ini.update~
UNLESS ~Ulthera_Quest~

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #20 on: May 08, 2008, 05:18:44 AM »
For whatever reason, both APPEND and APPEND_OUTER (which share 99% of the code) are adding a CRLF between the file and the new content, as well as basically changing broken expressions like CRCRCRLF to CRLF - but the regexp backfired. This behaviour is also present in W185, so I can't risk changing it and starting World War MDCLXVI again. I can cook up APPEND{_OUTER} file what DONT_FUCK_UP_CRLF though.
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Taimon

  • Planewalker
  • *****
  • Posts: 328
Re: Wish List
« Reply #21 on: May 08, 2008, 06:05:29 AM »
You need to take into account that, if the file is text and not empty, buff will usually end with CRLF or just LF.
(However, I'm not sure if this is somehow stripped when WeiDU reads the file.)
So buff ^ "\r\n" leads to a double CRLF which should get replaced by the regexp with just one CRLF.

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #22 on: May 08, 2008, 06:23:46 AM »
WeiDU reads the whole file as 8 bit reads, so it can't lose the ending CR.

The problem is that not all files actually end with CRLF (for some reason, Windows users forget to end their files with a CRLF, thus breaking all *nix utilities and then some).
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline the bigg

  • The Avatar of Fighter / Thieves
  • Moderator
  • Planewalker
  • *****
  • Posts: 3804
  • Gender: Male
Re: Wish List
« Reply #23 on: May 08, 2008, 07:13:03 AM »
Coded and uploaded the beta (you got my PM Qwinn?).
Author or Co-Author: WeiDU (http://j.mp/bLtjOn) - Widescreen (http://j.mp/aKAiqG) - Generalized Biffing (http://j.mp/aVgw3U) - Refinements (http://j.mp/bLHoCc) - TB#Tweaks (http://j.mp/ba02Eg) - IWD2Tweaks (http://j.mp/98OFYY) - TB#Characters (http://j.mp/ak8J55) - Traify Tool (http://j.mp/g1Ry9A) - Some mods that I won't mention in public
Maintainer: Semi-Multi Clerics (http://j.mp/9UeIwB) - Nalia Mod (http://j.mp/dng9l0) - Nvidia Fix (http://j.mp/aRWjjg)
Code dumps: Detect custom secondary types (http://j.mp/hVzzXG) - Stutter Investigator (http://j.mp/gdtBn8)

If possible, send diffs, translations and other contributions using Git (http://j.mp/aBZFrq).

Offline Qwinn

  • Planewalker
  • *****
  • Posts: 111
Re: Wish List
« Reply #24 on: May 08, 2008, 07:58:55 PM »
Yup, sure did.  Will test it shortly, I'm literally in the last hour or two of my initial coding phase for all 3 mods.

Qwinn

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: