Pocket Plane Group

Friends and Neighbors => Weimer Republic (WeiDU.org) => WeiDU => Topic started by: Kulyok on June 16, 2013, 11:02:09 AM

Title: Sound tag disappears if the same line exists without a tag
Post by: Kulyok on June 16, 2013, 11:02:09 AM
This is probably known, but I thought I'd report it anyway. Just noticed this in my mod:

Imagine you have two lines in your mod:
~What do you think?~
and
~What do you think?~ [SOUNDTAG]

Same text, but the second line has a sound tag. Now, this is how Weidu v231 treated these during traification.
It correctly assigned different tra lines to them:
@563  = ~What do you think?~
@594  = ~What do you think?~ [SOUNDTAG]

But it never used @594 in .d file: instead, it used @563 twice. I had to edit the second @563 manually. And I could've missed it easily during testing, but I didn't, so I want a cookie.
Title: Re: Sound tag disappears if the same line exists without a tag
Post by: Wisp on June 17, 2013, 01:31:33 PM
I can probably have a fix for this in the next version.
Title: Re: Sound tag disappears if the same line exists without a tag
Post by: Wisp on July 05, 2013, 10:35:53 AM
Okay, so this ended up as a fairly extensive rewrite of traify. Aside from correctly handling sounded and unsounded strings, the new traify also won't clobber your d, tp2, baf and tra files on syntax errors or for other silly reasons. You can also do things like "weidu --traify foo.d --traify-old-tra foo.tra" without WeiDU helpfully wiping foo.tra before attempting to read trarefs from it (instead foo.d will be retraified with trarefs from foo.tra and any new strings in foo.d will be appended to foo.tra).
Title: Re: Sound tag disappears if the same line exists without a tag
Post by: Kulyok on July 05, 2013, 02:04:00 PM
Great! Sounds too good to be true, in fact. Seriously, it sounds like a dream come true - I've been on the receiving end of Weidu helpfully wiping my tra once or twice, and it's a relief to know it won't happen anymore. And sound references, too(I found another replaced line in my mod). Thank you very much!