Pocket Plane Group

BG2 Completed Mods => Virtue => Topic started by: the bigg on October 05, 2005, 11:30:43 AM

Title: Two errors.
Post by: the bigg on October 05, 2005, 11:30:43 AM
163 IG(S:GLOBAL*,S:Area*D0VTYPE,I:Value*)

if this is short for 'Increment Global', you should change the 163 (ReputationInc) to 109  :)

Even better,IMHO it'd be better to completely do away without IG (which causes problems with decompiling some dialogues, EG trax.dlg) and change the general DLG patching to

Code: [Select]
COPY_EXISTING_REGEXP GLOB ~.*\.dlg~ ~override~
DECOMPILE_DLG_TO_D
REPLACE_TEXTUALLY ~ReputationInc(~ ~IncrementGlobal("D0Chg2","Global",~
COMPILE_D_TO_DLG
IF ~ReputationInc(~
BUT_ONLY_IF_IT_CHANGES
Title: Re: Two errors.
Post by: Ding0 on October 05, 2005, 06:02:15 PM
IG is a leftover from pre-DECOMPILE days, yeh. (Although you say it has problems with a DLG? I assumed it'd be more reliable than trying to decompile things.) Why on earth it's using the wrong IDS value, I don't know. It definitely worked at some point.
Title: Re: Two errors.
Post by: the bigg on October 06, 2005, 06:57:26 AM
IG is a leftover from pre-DECOMPILE days, yeh. (Although you say it has problems with a DLG? I assumed it'd be more reliable than trying to decompile things.) Why on earth it's using the wrong IDS value, I don't know. It definitely worked at some point.

It says that IG is expecting a string but finds an integer - maybe WeiDU doesn't like S:String*D0Vtype anymore, or something. Try decompiling Trax.dlg with the current version of Virtue installed, and then traifying it. (don't ask me what on Earth I was doing or testing, since I cannot recall, honestly  ;D )

In my tests, with DECOMPILE/COMPILE (after correcting the action.ids reference) I only get errors with BG1 leftovers, similar to those in the BCSes (Abela, Charle, Nobw8, Prism, Quinn, Silke.dlg).