Pocket Plane Group

Friends and Neighbors => Weimer Republic (WeiDU.org) => WeiDU => Topic started by: CamDawg on May 18, 2005, 07:33:32 AM

Title: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: CamDawg on May 18, 2005, 07:33:32 AM

While doing speed testing for the new v178 with G3 Tweaks, I came across a bug with top-level install options and SUBCOMPONENT groups. I generally include ASK_EVERY_COMPONENT so this had not been previously observed.

When presented with the top-level options, I chose to nstall everything not currently installed. WeiDU installed every individual SUBCOMPONENT in the two SUBCOMPONENT groups present in the mod. I don't know how WeiDU should handle SUBCOMPONENT choices by default (always pick the first option?), but installing all of them is probably not my choice. :)

However, this did not apply on uninstall. When choosing to uninstall, either by using a top-level uninstall or going through every component, I could only uninstall the SUBCOMPONENTs one at a time.

In full disclosure, the SUBCOMPONENTs in G3 Tweaks also use DESIGNATED component numbers, in case this complicates the matter. The bug was also present in v176.

Title: Re: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: SimDing0™ on May 18, 2005, 07:49:22 AM

I thought I checked this and found that the first subcomponent out of a set would be installed. Maybe I was careless. I'll try it again and see if I get the same behaviour.

Title: Re: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: weimer on May 18, 2005, 11:10:14 AM

I don't have any mods with components for easy testing. Can one of you post/send me some way to reproduce this problem locally?

Title: Re: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: CamDawg on May 18, 2005, 05:38:02 PM

OK, this is definitely a conflict between DESIGNATED and SUBCOMPONENT. (I knew there was a reason why we aren't supposed to use this. :p ) Without DESIGNATED, WeiDU installs the first option only when issued a top-level install all. However, the following will generate an install of every SUBCOMPONENT as initially reported:

Code: [Select]

BACKUP ~ams/backup~ // location to store files for uninstall purposes
AUTHOR ~webmaster@gibberlings3.net~ // email address displayed if install fails

BEGIN ~Dummy 1~
BEGIN ~Dummy 2~
BEGIN ~Dummy 3~
BEGIN ~Dummy 4~
BEGIN ~Dummy 5~

BEGIN ~Sub Test 1~
DESIGNATED 10
SUBCOMPONENT ~foo~

BEGIN ~Sub Test 2~
DESIGNATED 20
SUBCOMPONENT ~foo~

BEGIN ~Sub Test 3~
DESIGNATED 30
SUBCOMPONENT ~foo~
On to your G3T timings. :)

Title: Re: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: weimer on May 18, 2005, 06:39:52 PM

With the small tp2 file I was able to fix this.

Title: Re: [v178 bug] SUBCOMPONENTs and top-level install options
Post by: CamDawg on May 18, 2005, 06:42:30 PM

Rock on. Thanks!