Author Topic: Exiting Setup-Mod.exe via X button: can't install other mods (Read 12655 times)

Kulyok · « **on:** August 04, 2007, 10:32:14 AM »

We're having a problem here with WeiDU 200:

Now each time Setup-Mod.exe runs, it creates a weidu.lock file in BG2 directory with its own path and name. While the file is there, the user can't launch any other Setup-Mod2.exe - Weidu will tell him "Sheesh, don't run two mods at once!" After the user installs the mod and presses Enter in the end, the file disappears.

However. If a user exits Setup-Mod.exe via pressing X button, weidu.lock remains here. So, unless the user deletes it manually, the user is not able to install other mods. Ever. Again.

(And the bigg is on holiday.)

So. Um. Yeah.

cmorgan · « **Reply #1 on:** August 04, 2007, 12:40:35 PM »

As posted on SHS:

Confirmed on retest.

WeiDU 200 acts as expected. At the end of an install, or at any time you use Q to quit, WeiDU asks you to press enter. Doing this results in expected behavior; WeiDu releases the lock and lets you proceed.

If, on the other hand, you yank the plug on the process by blowing it away instead of following the directions, ~~on your head be it and a plague on all your house even unto the seventh generation, I say verily unto thee~~ expect there to be serious problems

There is no more a fix for this than there is for running your car into a pedestrian. Just don't do it, for *any* command line program. Noone likes their little universe imploded; especially programs.

the bigg · « **Reply #2 on:** August 10, 2007, 08:40:41 AM »

I can make the message more explicit and delete the file when "press enter to exit" is pressed.

cmorgan · « **Reply #3 on:** August 10, 2007, 10:40:22 AM »

It could not hurt to make the message more obvious; perhaps a warning up front reminding folks that in order for the installer to work it is important to follow directions?

I am not sure how to say "don't close WeiDU via the litle "x" on your screen - only close it by following directions and pressing "enter"."

Bookwyrme · « **Reply #4 on:** August 10, 2007, 11:08:35 AM »

Quote from: cmorgan on August 10, 2007, 10:40:22 AM

I am not sure how to say "don't close WeiDU via the litle "x" on your screen - only close it by following directions and pressing "enter"."

I think you just said it.

the bigg · « **Reply #5 on:** August 10, 2007, 11:09:20 AM »

It might be possible to force Windows to delete the lock file if closing via the X button, but it is easier to simply delete the lock file before displaying "please press enter to exit" (not to mention that forcing Windows to do stuff is not easy).

Kulyok · « **Reply #6 on:** August 10, 2007, 11:37:18 AM »

Deleting the file before displaying that message would help. There'll still be a problem of these users who close their setup-exe's in the middle of their installations, though(for example, if they installed an NPC mod and decided to skip 'optional portrait' component).

the bigg · « **Reply #7 on:** August 10, 2007, 12:04:08 PM »

In which case, they'd deserve all bugs they get.

Kulyok · « **Reply #8 on:** August 10, 2007, 12:18:14 PM »

Yes, but imagine users doing it for several years and not getting any bugs, and then all of a sudden... I guess we'll just have to see how many "can't install this!" bug reports there'll be; I'm just worried I'll have to deal with my share, so to say.

the bigg · « **Reply #9 on:** August 10, 2007, 12:23:35 PM »

They seem few enough as of now. Users doing as you say for years would suffer from broken .tlk anyway.

(I wish there was a way to display a pop up saying "YOUR AN IDIOT" if an user decides to close weidu via the x button. That'd be a much easier way to deal with the problem).

berelinde · « **Reply #10 on:** August 10, 2007, 01:20:40 PM »

Part of that is probably moving the decompression of sound and area files from the end of the installation to the middle or beginning. Users were accustomed to waiting until all the sound files and tiles unpacked, so they'd wait until they got to the ENTER prompt, but now they don't have to, so they just close it with components still in the cue.

Gotta say that I've made just about every mistake possible while installing a mod from attempting it with the game running to trying to install two at once, to installing it in the wrong directory, but I would have never thought of hitting that x. Mostly because I was so sure I'd do it wrong that I wouldn't feel safe until it said it was done, and that it was safe to hit ENTER.

jastey · « **Reply #11 on:** August 22, 2007, 01:43:10 AM »

I received the "you cannot install two mods at the same time" prompt when trying to reinstall the same mod (WeiDU 200, BG1NPC preversion). I definitely did close any setup window with ENTER, not using the "x", that is for sure.

But I had a lot of CTDs before, from BGTutu because of a (confirmed) EDIT: engine! - bug, so I don't know what exactly happened there.

Rabain · « **Reply #12 on:** August 22, 2007, 03:11:54 AM »

Is there any chance of having the option to turn the creation of the lock file off? It's really annoying.

the bigg · « **Reply #13 on:** August 22, 2007, 11:09:50 AM »

In the next version of WeiDU weidu.lock will be ignored if it is empty (= you manually create an empty weidu.lock file in the bg2 directory).
If, once more W201 mods start being released (= where you can also close via 'X'), we'll continue to have lots and lots of people reporting "You can't install this", I'll remove the feature altogether.

the bigg · « **Reply #14 on:** September 03, 2007, 07:00:48 AM »

This is the error message in WeiDU 201. Please provide feedback as to wether it's clear enough.
Also, manually saving an empty WeiDU.lock file would disable the feature (which you can do anyway by typing "two" at this prompt)

Code: [Select]

You cannot install more than one mod at a time or you will have bugs.

Try to install the mod once again, after the following:
blah_blah
has finished.

In the future, don't close the setup-xxx.exe window with the 'x' icon, but press
ENTER once instructed. Failure to do so (especially if you close via 'x' before
"Press ENTER to exit." is displayed) WILL result in a broken game.

If you are sure you received this message in error, then please type `one'
  (without the quotes) and press ENTER to continue.
If you are an advanced user and would like to forever disable this message, then
  please type `two' (without the quotes) and press ENTER to continue.

Press ENTER to exit.

Rabain · « **Reply #15 on:** September 03, 2007, 02:12:53 PM »

Sounds good to me.

Not that I'd ever do this but what would you think of someone possibly including an empty weidu.lock in a mod release?

I just thought of this when I read your post.

the bigg · « **Reply #16 on:** September 03, 2007, 03:44:03 PM »

Quote from: Rabain on September 03, 2007, 02:12:53 PM

Not that I'd ever do this but what would you think of someone possibly including an empty weidu.lock in a mod release?

I'm not going to stop you (or whomever), but ideally it's there for the modder's benefit, since its aim is to block, or reduce, people reporting dialog.tlk problems, if they happen because the user runs two setup-xxx.exe or close 'too early' via the 'x' button.

If it proves to cause more modder headaches than a broken .tlk (= statistically you get more weidu.lock reports than you were getting "wrong lines"), then I'll remove the feature.

berelinde · « **Reply #17 on:** September 04, 2007, 06:00:23 AM »

I've noticed something while using WeiDU to test-compile prior to a debugging run: if everything goes fine during the installation, the weidu.lock is removed after hitting ENTER, but if I got a parse error (I did say it was a debugging run, didn't I?), the weidu.lock remained after hitting ENTER and had to be manually deleted.

Naturally, our released mods won't have parsing errors, so this is a non-issue, but I thought I'd bring it up anyway.

the bigg · « **Reply #18 on:** September 04, 2007, 06:28:15 AM »

What command line did you use? Or did you refer to running setup-xxx.exe when setup-xxx.tp2 doesn't parse?

berelinde · « **Reply #19 on:** September 04, 2007, 06:57:20 AM »

Er, sorry I wasn't clear. Technical terms aren't my strong suit, so I'll describe what I was doing in more detail, in the hopes that it answers that question.

I was running the regular weidu installer, using the setup-xxx.tp2 to install a mod that contained errors, like missing tildes, missing END's at the end of APPEND's, that kind of thing. Setup-xxx.tp2 was working just fine. It was the files that had bad code. I'd get the error message like I should, would select "quit" to stop the installation, hit ENTER to exit, the command window would close, I'd go fix the files that were messed up, and restart the installer. When the installer didn't hit any errors in the files it was compiling, the weidu.lock was deleted as I expected it to be, but if I did have errors severe enough to stop the installation, the weidu.lock remained after hitting ENTER to close the command window.

Kulyok · « **Reply #20 on:** September 04, 2007, 07:22:12 AM »

I'm rather afraid a part of my target audience doesn't pay attention to error messages, even well-written and detailed - especially when we're talking about foreign players. I mean, take a girl who just bought a computer, needs her brother or her dad to teach her how to install Baldur's Gate, and the only thing she can do with a mod is to 1) run .exe file; 2) if she sees a mistake, she deletes it and doesn't play it again, because she's too shy to post on the forums. (That's not some abstract girl, it's me - around the time SoA came out).

I love WeiDU to bits, and AT_NOW will have my heart forever - but as for this feature, I'm scared for these girls I mentioned.

Gort · « **Reply #21 on:** September 04, 2007, 11:55:03 PM »

the problem is that you consider people "advanced" enough to not close setup window via "x" button and at the same time "unadvanced" enough to install 2 mods at the same time. There's no such people, so this feature is vain. I use words "advanced" and "unadvanced" intentionally, as knowledge of computers has absolutely nothing to do with intelligence.

the bigg · « **Reply #22 on:** September 05, 2007, 04:42:03 AM »

If somebody really knows what he's doing, he might be able to ctrl-c a mod install when he knows it won't cause problems (E.G. the tp2 doesn't overwrite override files, but works on a temp directory), and/or can fix weidu.log after force-stopping an installation.

Advanced people aren't those that never make stupid mistakes, they're those that can fix up the mess afterwards and learn from experience

Azazello · « **Reply #23 on:** September 07, 2007, 03:12:31 PM »

bigg, you're spending too much calories on these recent weidu issues. Just notify people that they have the power to fork the build.

the bigg · « **Reply #24 on:** September 07, 2007, 07:43:26 PM »

News:

Author Topic: Exiting Setup-Mod.exe via X button: can't install other mods (Read 12655 times)