Author Topic: GAME_IS documentation  (Read 380 times)

Offline CamDawg

  • Infidel
  • Planewalker
  • *****
  • Posts: 832
  • Dreaming of a red Xmas
    • The Gibberlings Three
GAME_IS documentation
« on: January 06, 2019, 06:40:00 PM »
Is it documented anywhere what GAME_IS actually checks?

Every one in a (long) while I'll get some screwy bug report where a GAME_IS apparently flows down the wrong path of the logic check. I'm willing to bet it's typically an error in my code somewhere, but it would be nice to see this delineated somewhere.
« Last Edit: January 06, 2019, 06:40:39 PM by CamDawg »
The Gibberlings Three - Home of IE Mods

The BG2 Fixpack - All the fixes of Baldurdash, plus a few hundred more. Now available, with more fixes being added in every release.

Offline Mike1072

  • Planewalker
  • *****
  • Posts: 296
  • Gender: Male
Re: GAME_IS documentation
« Reply #1 on: January 06, 2019, 09:44:20 PM »

Offline The Imp

  • Planewalker
  • *****
  • Posts: 278
  • Gender: Male
Re: GAME_IS documentation
« Reply #2 on: January 07, 2019, 06:56:50 AM »
So technically, nope. :P

Offline Wisp

  • Moderator
  • Planewalker
  • *****
  • Posts: 1031
Re: GAME_IS documentation
« Reply #3 on: January 07, 2019, 11:12:05 AM »
What GAME_IS checks is a so-called implementation detail and may be subject to change, should a situation arise where some check would need to be altered in order for GAME_IS to function as documented. The contract (subject to documentation) is that GAME_IS says what game it is. How it arrives at that conclusion is not part of the contract.

Offline The Imp

  • Planewalker
  • *****
  • Posts: 278
  • Gender: Male
Re: GAME_IS documentation
« Reply #4 on: January 08, 2019, 06:09:38 PM »
By the way, how did you Mike "search" the GitHub code for the specific code ? Was it that you knew this to be there, or ... asking cause it could help me build off from the weidu's own functionality, as it's sometimes easier to reduce than expand.

Offline Mike1072

  • Planewalker
  • *****
  • Posts: 296
  • Gender: Male
Re: GAME_IS documentation
« Reply #5 on: January 08, 2019, 09:19:25 PM »
I had seen it previously so I knew it existed.

I couldn't remember exactly where it was off-hand, so I searched for GAME_IS to track down what it was mapped to (PE_GameIs) and then searched for PE_GameIs and found the implementation in tppe.ml.

You can search a repo by entering text in the textbox in the top left.  It doesn't usually let you search within a repo if that repo is a fork, so you have to go to the main repo and search there.

Offline The Imp

  • Planewalker
  • *****
  • Posts: 278
  • Gender: Male
Re: GAME_IS documentation
« Reply #6 on: January 08, 2019, 10:24:17 PM »
So you go into the main repo, push the "Find file" button on the middle top right, which open the "repo path" in the left corner that allows you to search for terms, and find files that contain it. And of course then one can use the browsers own search funtion to find the specific cases, in a long file.
Good, thanks.

Offline Mike1072

  • Planewalker
  • *****
  • Posts: 296
  • Gender: Male
Re: GAME_IS documentation
« Reply #7 on: January 08, 2019, 11:14:30 PM »
No, I enter my text in the textbox in the top left, like I said.

Maybe this will help.

Offline The Imp

  • Planewalker
  • *****
  • Posts: 278
  • Gender: Male
Re: GAME_IS documentation
« Reply #8 on: January 09, 2019, 06:00:38 AM »
Maybe this will help.
Uuh, that requires one just to log into the github. Aah... so yes, it did. Thanks much man.

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: