lol

[the bigg]

Code:

MOVE ~source~ ~destination_with_%variables%~

With that (and a couple  of extra tweaks), gen_biff now can biff 26K files (http://pastebin.com/f134f2341) in eight minutes... On a 5400 hard disk:

Code:

WeiDU Timings
<...>
stuff not covered elsewhere     11.380
MOVE                           110.918
BIFF                           337.897
TOTAL                          480.549

(suitably enough, Winamp is playing this as I type this).

[Azazello]

Code:

MOVE ~source~ ~destination_with_%variables%~

With that (and a couple  of extra tweaks), gen_biff now can biff 26K files (http://pastebin.com/f134f2341) in eight minutes... On a 5400 hard disk:

Code:

WeiDU Timings
<...>
stuff not covered elsewhere     11.380
MOVE                           110.918
BIFF                           337.897
TOTAL                          480.549

(suitably enough, Winamp is playing this as I type this).

Yay?

[cmorgan]

Great taste in music, man!

Good breakthrough!

[Miloch]

The readme says about MOVE:

Safety notes: when uninstalling, MOVE is restored first, then all generic actions are restored, then AT_*!UNINSTALL is handled. As such, do your AT_NOW, then do your COPY, then do your MOVEs

As discussed elsewhere, we want to move buggy files out of the override before COPYing over proper ones. The main reason we can't just overwrite the old ones is because they don't all have the same names as the one's we're copying. We do this by batch files now but I'm considering recoding it to use MOVE. Is this going to cause issues at uninstall?

[the bigg]

Can't you just write a sample tp2 and try it out? 

If there is no filename collision this is a non-issue; if there is a collision, the file is completely deleted from the override. I don't know the specifics of your mod, but on a general basis it's an issue.

[Miloch]

Can't you just write a sample tp2 and try it out? 

My goal was to get some sort of answer (or informed opinion at least) before coding something that may or may not be useful. Mainly because I spent loads of time writing the batch files to begin with but would prefer to dump those if feasible. The collision thing I'm not sure of. Certainly, before Infinity Animations, several mods may have overwritten these BAMs but after it we would hope not (since it should be installed near the end).

[the bigg]

The problem is if a mods installed before IA have filename collisions with IA, not with those installed after.

Code:

BACKUP ~test/backup~
AUTHOR ~tb~

BEGIN ~0~
<<<<<<<< .../newfoobar
old
>>>>>>>>

COPY ~.../newfoobar~ ~test/prod/foobar~


BEGIN ~1~

MOVE ~test/prod/foobar~ ~test/prod/oldfoobar~
<<<<<<<< .../newfoobar
new
>>>>>>>>

COPY ~.../newfoobar~ ~test/prod/foobar~

Install 0 and 1, uninstall 1 (simulate the case where a mod installed before IA collides with IA). Correct uninstall behavior would be to have foobar contain "old". However, the file is removed.

UNINSTALL_MOVE_AFTER_COPY tp2 flag incoming. This is the predicted end result.

[Miloch]

UNINSTALL_MOVE_AFTER_COPY tp2 flag incoming.

Serious or a joke? Either way, sounds like I should stick with the batch files until something like that exists.

[the bigg]

It's going in.

[Miloch]

Apparently some folks and memory-resident programs have been whinging about the MOVE command. Personally, I think it's antivirus (typically Avast to be specific), since it almost always goes away when disabling it. Moreover, this is rarely reproduceable in the same way, in that it hangs up on *different* files with some vague, bogus error message (such as "error copying somefile.bam" or "Patching failed (COPY)"). But some folks claim otherwise, in some very specific situations (such as if RoT and Aurora are installed). Since I'm not familiar with the code, is it at all possible a trifling code change such as specifying a destination file rather than folder would make a difference, as claimed here?

[the bigg]

Yes, you need to specify the full destination (including the filename). I thought nobody would use it, so I coded it in the quickest possible way (and obviously the underlying OCaml library is the usual piece of shit and doesn't add the filename if given a directory). 214 will allow you to specify just the destination folder.