Author Topic: Incompatibility between Bg2Fixpack and Restored Minor Dialogs  (Read 5698 times)

Offline White Agnus

  • Planewalker
  • *****
  • Posts: 18
Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« on: November 03, 2009, 02:29:48 AM »
Hi,
I found a little incompatibility between the main component of BG2Fixpack and Restored Minor Dialogs of UB...
Both Mods restores the docsol03.cre in AR0332.are, that breds a loop in the dialog, because docsol02.cre is needed...

How about changing
Code: [Select]
COPY_EXISTING ar0332.are override
  READ_LONG 0x54 act_off
  FOR (READ_SHORT 0x58 act_num; act_num; act_num -= 0x01) BEGIN
    READ_ASCII act_off + 0x110 * act_num - 0x90 cre
    PATCH_IF ~%cre%~ STRING_EQUAL_CASE docsol02 BEGIN
      WRITE_ASCII act_off + 0x110 * act_num - 0x90 docsol03
      SET act_num = 0x01
    END
  END
BUT_ONLY

to:

Code: [Select]
ACTION_IF NOT (MOD_IS_INSTALLED ~setup-bg2fixpack.tp2~ ~0~) THEN BEGIN
COPY_EXISTING ar0332.are override
  READ_LONG 0x54 act_off
  FOR (READ_SHORT 0x58 act_num; act_num; act_num -= 0x01) BEGIN
    READ_ASCII act_off + 0x110 * act_num - 0x90 cre
    PATCH_IF ~%cre%~ STRING_EQUAL_CASE docsol02 BEGIN
      WRITE_ASCII act_off + 0x110 * act_num - 0x90 docsol03
      SET act_num = 0x01
    END
  END
BUT_ONLY
END

Because i think, in the most cases hte Fixpack will be installed first... ;)

Offline Leomar

  • Planewalker
  • *****
  • Posts: 116
  • Gender: Male
Re: Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« Reply #1 on: February 03, 2010, 10:16:04 AM »
Here are some more infos about the problem:
http://forums.gibberlings3.net/index.php?showtopic=19252

And this is Wisp's comment about it:
Quote
This will still be a clash between UB and Expanded Thief Stronghold, though.

Greetings Leomar

Offline aVENGER

  • Planewalker
  • *****
  • Posts: 143
Re: Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« Reply #2 on: March 02, 2010, 09:48:44 PM »
Hi,
I found a little incompatibility between the main component of BG2Fixpack and Restored Minor Dialogs of UB...
Both Mods restores the docsol03.cre in AR0332.are

In all likelihood, we are going to remove this restoration from the fixpack as of v9. Therefore, it would be better to use a more robust check to see if some other mod might have restored the creature prior to Unfinished Business. For example:

Code: [Select]
COPY_EXISTING ar0332.are override
PATCH_IF NOT FILE_CONTAINS_EVALUATED (~%SOURCE_FILE%~ ~docsol03~) BEGIN
  READ_LONG 0x54 act_off
  FOR (READ_SHORT 0x58 act_num; act_num; act_num -= 0x01) BEGIN
    READ_ASCII act_off + 0x110 * act_num - 0x90 cre
    PATCH_IF ~%cre%~ STRING_EQUAL_CASE docsol02 BEGIN
      WRITE_ASCII act_off + 0x110 * act_num - 0x90 docsol03
      SET act_num = 0x01
    END
  END
END
BUT_ONLY

Furthermore, it might be a good idea to add this code to UB in order to prevent the aforementioned dialogue loops:

Code: [Select]
COPY_EXISTING ~docsol03.bcs~ ~override~
DECOMPILE_BCS_TO_BAF
  REPLACE_TEXTUALLY EXACT_MATCH ~See([PC])~ ~See([PC]) InMyArea("docsol02") !StateCheck("docsol02",CD_STATE_NOTVALID)~
COMPILE_BAF_TO_BCS
BUT_ONLY_IF_IT_CHANGES

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6253
  • Gender: Female
  • The perfect moment is now.
Re: Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« Reply #3 on: August 08, 2013, 06:17:53 AM »
Is there still an incompatibility and should UB still add anything?

Offline CamDawg

  • Infidel
  • Planewalker
  • *****
  • Posts: 859
  • Dreaming of a red Xmas
    • The Gibberlings Three
Re: Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« Reply #4 on: August 08, 2013, 09:50:07 AM »
Fixpack (as of v10) no longer messes with ar0332.
The Gibberlings Three - Home of IE Mods

The BG2 Fixpack - All the fixes of Baldurdash, plus a few hundred more. Now available, with more fixes being added in every release.

Offline Kulyok

  • Global Moderator
  • Planewalker
  • *****
  • Posts: 6253
  • Gender: Female
  • The perfect moment is now.
Re: Incompatibility between Bg2Fixpack and Restored Minor Dialogs
« Reply #5 on: August 08, 2013, 10:02:21 AM »
Thank you. Seems like Big World Fixpack uses Avenger's code anyway(for RR, I presume), so added.

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color is grass?:
What is the seventh word in this sentence?:
What is five minus two (use the full word)?: