Author Topic: DevSin's Changes (Q/A/Discussion)  (Read 16484 times)

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
DevSin's Changes (Q/A/Discussion)
« on: July 22, 2006, 02:08:53 PM »
I'm just going through DevSin's changes and I thought this deserved it's own thread (I'm getting in deep, and I'm going to need DevSin's help :) )

The changes are substantial and look like they quite significantly improve NearInfinity.  I'm just now trying to break up the changes into categories:

  • Architecture Support:
  • Any changes for better architectecture support (versions of OS, Java, etc).  In particular, DevSin has changes for supporting MacOSX.
  • Bug Fixes:
  • Pretty obvious: any changes that prevent program failure or incorrect program behavior.
  • Enhancements:
  • New features or improvements.
  • Coding Style:
  • This one is prone to personal bias on my part, but I want to try and weed out the change that represent differences in coding style so that it's easier to browse the other changes.  Sometimes a change in coding style leads to a bug fix, so this one isn't as clear cut as it seems.

As I said, the changes are substantial.  The diff file is 14000 lines (that's excluding differences in white space).  I'm going to start off by taking out the last category of changes (Coding Style) so that I can more easily review the other types of changes.  I'll post again when I get further along or when I get stuck :)

Offline Avenger_teambg

  • Planewalker
  • *****
  • Posts: 393
Re: DevSin's Changes (Q/A/Discussion)
« Reply #1 on: July 23, 2006, 07:35:41 AM »
There are 2 other alternatives:

1. blindly apply all changes, if something breaks, blame DevSin.
2. give him SF access, if something breaks, blame DevSin.

Well, just an idea :)

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #2 on: July 23, 2006, 09:02:03 AM »
There are 2 other alternatives:

1. blindly apply all changes, if something breaks, blame DevSin.
2. give him SF access, if something breaks, blame DevSin.

Well, just an idea :)

:D  This is what I'd really like to do.  Based on the amount of work DevSin has done, he really should be the lead developer on this.

I don't know if he's interested in this (DevSin, are you?  Please let me know!).  But it's also worth reviewing what's there so long as someone (me) has the energy to do it.

Of course, if I completely run out of steam I'll probably accept the changes whole-sale as they are, but I at least want to try and go through them.

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #3 on: July 23, 2006, 09:17:44 AM »
String Changes:

There are a lot of renamed fields.  Some of this is "regionalized" :)  (Dialog -> Dialogue), but in general the changes improve the clarity of the various field description ("L. Ring" -> "Left Ring"), in other cases there are spelling correctoins.

Mixed in with these changes are new field descriptions that were "unknown", and what are probably corrected field descriptions.  I'm not sure I'm completely qualified to review the corrected field changes or not.

Since I happen to own all the relevent games (PS:T, BG1/2/ToB, IWD1/2), I can probably at least test to make sure Dev's changes work with all the games under XP.  I'll try to be good for something :)

Offline Grim Squeaker

  • Fallen
  • Planewalker
  • *****
  • Posts: 1019
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #4 on: July 23, 2006, 10:45:11 AM »
Quote
Since I happen to own all the relevent games (PS:T, BG1/2/ToB, IWD1/2), I can probably at least test to make sure Dev's changes work with all the games under XP.  I'll try to be good for something Smiley

Not sure if any of the relevant code has been touched in the latest updates, but keep in mind that NI also works for NWN.
"You alone can make my song take flight..."

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #5 on: July 23, 2006, 11:08:46 AM »
How well did it support NWN?  I always figured that the NWN community primarily used other tools (like the bioware ones).

JOH also mentions KoToR, but I have no idea how well that's supported.

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #6 on: July 23, 2006, 11:31:08 AM »
You shouldn't apply my changes wholesale. If you want to do it a file at a time, you can post the filename and rough overview, and I should be able to comment on or explain some particular changes. There are also some that I don't think should be merged in, and some I feel that probably should be discussed. Discretion, of course. If I added a qualifier (like final) or something similarly uninteresting, you could just do whatever you want. If you're working on file X on a particular day, you could always just post the diff and ask for comments.

You could add me to the developers, but I probably won't ever really do any work on it, and I'm certainly not the person to maintain it. One of the reasons the code style is different is that I had no intention of distributing the changes, and turning it into something that I can easily read allowed me to work pretty quickly (I only messed with it for a couple of weeks).

For now, I'd ignore changes that simply correct, clarify, or make consistent item labels. The structure updates should be universal (the game is the same on both platforms), and I was pretty careful about checking stuff before making the change. Once these get rolled in, it can be re-diffed and these items can be considered, or they can just be left as they currently are if you run out of steam.

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #7 on: July 23, 2006, 11:36:19 AM »
All of the Aurora data types are completely different. I did not touch any of that stuff, and none of my changes should affect Aurora file viewing (I don't think NI yet supports editing).

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #8 on: July 23, 2006, 11:40:32 AM »
There are a lot of renamed fields.  Some of this is "regionalized" :)  (Dialog -> Dialogue), but in general the changes improve the clarity of the various field description ("L. Ring" -> "Left Ring"), in other cases there are spelling correctoins.
My region is California. ;-) "Dialogue" is always correct, never "dialog." There may be an English-speaking country out there that uses it, but I can't think of one offhand.

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #9 on: August 04, 2006, 06:03:58 PM »
Sorry to take so long to get back here.  Everything you said makes perfect sense.  I'll definitely go through the changes more carefully.  I tend to take a more conservative approach.

I'll be able to do a bit more work on this over the weekend.

There are a lot of renamed fields.  Some of this is "regionalized" :)  (Dialog -> Dialogue), but in general the changes improve the clarity of the various field description ("L. Ring" -> "Left Ring"), in other cases there are spelling correctoins.
My region is California. ;-) "Dialogue" is always correct, never "dialog." There may be an English-speaking country out there that uses it, but I can't think of one offhand.

I didn't know this!  My spelling is bad enough anyway =)

Offline Blucher

  • Planewalker
  • *****
  • Posts: 44
Re: DevSin's Changes (Q/A/Discussion)
« Reply #10 on: August 04, 2006, 06:23:24 PM »
"Dialogue" is always correct, never "dialog." There may be an English-speaking country out there that uses it, but I can't think of one offhand.

"Dialog" is just a Biowarism I think.

Actually it is a recognized variant of Dialogue, it's just...erm...slangish. (I don't think that's a word either. ;))

Offline Rabain

  • Planewalker
  • *****
  • Posts: 281
  • Gender: Male
  • Luck o' the Irish!
Re: DevSin's Changes (Q/A/Discussion)
« Reply #11 on: August 05, 2006, 03:41:18 AM »
They probably did that after a dozen mistakes of typing Dialouge instead of Dialogue and I still see that mistake a dozen times a week around the fora.
Touchstone: Wild Elf Fighter
BG2CPM: Dialog Portraits for Everyone!
WTPFamiliars: A new version of the Find Familiar Spell
All at: Border Kingdoms

Offline jcompton

  • Niche Exploiter
  • Administrator
  • Planewalker
  • *****
  • Posts: 7224
Re: DevSin's Changes (Q/A/Discussion)
« Reply #12 on: August 05, 2006, 09:12:08 AM »
As has been mentioned, it _is_ a valid dictionary word, but usually more associated with programming ("dialog box") than with conversation ("holding a dialogue between the two parties.")

And amusingly, the built-in browser spellchecker doesn't like "dialogue." But then, it doesn't like "spellchecker" either, so the hell with it.
Cespenar says, "Kelsey and friends be at the Pocket Plane? Ohhh yesssss!" http://www.pocketplane.net

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #13 on: August 05, 2006, 03:55:23 PM »
I should have clarified that "dialogue" is the proper spelling in the context we were discussing. Dialog is used often enough that I wouldn't consider it wrong, but it is the less proper of the two.

Modal windows are referred to as "dialogs."

Although you can, don't use "dialogue" as a verb.

Offline NiGHTMARE

  • Idiot
  • Planewalker
  • *****
  • Posts: 1405
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #14 on: August 05, 2006, 04:43:12 PM »
Let's start with the small stuff (e.g. getting people to recognize when to use "your" and when to use "you're") before moving on to more complicated things :).
The Gibberlings Three - home to the BG1 NPC Project, BG2 Tweak Pack, Divine Remix, GemRB, Lands of Intrigue, Song & Silence, and many more!

Offline Caedwyr

  • Planewalker
  • *****
  • Posts: 433
Re: DevSin's Changes (Q/A/Discussion)
« Reply #15 on: August 05, 2006, 06:43:00 PM »
Let's start with the small stuff (e.g. getting people to recognize when to use "your" and when to use "you're") before moving on to more complicated things :).

Like were, where, wear, we're.
"Knowledge is Power.  Power Corrupts.  Study Hard.  Be Evil."  - Mikka

PnP Celestials
Geomantic Sorcerer Kit

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #16 on: January 07, 2007, 05:01:07 PM »
I put up a better build with better source of my crap. It should be a *lot* more diffriendly (all but EffectFactory), and I don't really have any reservations with just dumping in the changes en masse. There are one or two changes I'd want to make afterward, but I don't care enough right now to update the source archive. ;)

JAR
Source

EDIT: (1/9/07) source archive updated with latest changes (for Fred)
EDIT: (1/27/07) JAR and source archive updated with minor changes
« Last Edit: January 27, 2007, 01:52:00 PM by devSin »

Offline berelinde

  • Planewalker
  • *****
  • Posts: 1188
  • Gender: Female
    • Gavin, cleric of Lathander, for Tutu
Re: DevSin's Changes (Q/A/Discussion)
« Reply #17 on: January 07, 2007, 06:20:14 PM »
Is there an actual new version of NI on the horizon?

Offline cmorgan

  • Planewalker
  • *****
  • Posts: 1408
  • Gender: Male
  • Searcher of Bugs
Re: DevSin's Changes (Q/A/Discussion)
« Reply #18 on: January 07, 2007, 09:39:15 PM »
That JAR is wicked cool - lots more info. Thank you for putting it up.

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #19 on: January 07, 2007, 10:52:42 PM »
I put it up forever ago. I hid it in Cam's playthrough bugs in the fixpack forum to keep the undesirables away. :D

It's recent enough and shouldn't contain any bugs that weren't in previous 1.33 betas, but don't use it with nuclear materials or anything. There might be a small issue with the precedence of some checks somewhere that I introduced that I'd want to reinforce, but you shouldn't ever see it. There's also a couple issues with the world map where the IESDP is wrong (for BG2, at least), some minor spelling errors, and I didn't add support for Mac NWN (I've since done it locally), but it's pretty much all I'm ever going to do with it.

Make sure to read the license if you want to modify and/or redistribute. But you should probably just wait for Fred to roll it into the SourceForge tree (someday!).

Offline Miloch

  • Barbarian
  • Planewalker
  • *****
  • Posts: 1022
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #20 on: January 08, 2007, 09:57:49 AM »
Undesirables = people with little knowledge who might request enhancements?

Like for example, how hard would it be to add Ascension64's beregost.class (Tutu Beregost crash fixer) to the JAR?  I'd do it myself but I know very little (i.e., nothing) about Java.

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #21 on: January 08, 2007, 12:41:20 PM »
Undesirables == people who don't read the fixpack forum, I guess.

You can shoot notes to Fred or igi if you have questions or suggestions; it's their project.

The JAR I've posted features only things I actually cared (and had the time) to change, but I don't have any interest in maintaining it or otherwise modifying it.

Offline Ascension64

  • Planewalker
  • *****
  • Posts: 472
Re: DevSin's Changes (Q/A/Discussion)
« Reply #22 on: January 08, 2007, 07:54:04 PM »
You might not need to...the Beregost thing is probably a little too wayward to add to a general editor like NearInfinity, after some thought about it. I'm working on a GUI-based version that can process SAV files directly...it's going well.

Offline FredSRichardson

  • Moderator
  • Planewalker
  • *****
  • Posts: 188
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #23 on: August 22, 2007, 07:32:51 PM »
Okay, it's been forever and a day since I last worked on this.  And DevSin has made up for it by providing his change ;)

I've merged in DevSin's stuff with my last release, so it really looks like DevSin's code with a few minor tweaks.  I guess the biggest difference is that my files have Windows EOL format (CRLF) while DevSin's are in Mac EOL format (CR).  The other option out there is to use *nix EOL format (LF).  I'm not big fan of Windows, but I'd settle on CRLF format so long as we can all deal with it.

I'll try to get this version up for review pretty soon.

Offline devSin

  • Planewalker
  • *****
  • Posts: 1631
  • Gender: Male
Re: DevSin's Changes (Q/A/Discussion)
« Reply #24 on: August 23, 2007, 12:38:29 AM »
I guess the biggest difference is that my files have Windows EOL format (CRLF) while DevSin's are in Mac EOL format (CR).  The other option out there is to use *nix EOL format (LF).  I'm not big fan of Windows, but I'd settle on CRLF format so long as we can all deal with it.
Say what? They better be CRLF or LF. I put my hand on the bible that I haven't saved anything with CR line endings in the last five years, and if there are CR line breaks in that code, they didn't come from me.

I edited a couple of files directly in NetBeans, which may have tried to be helpful and use CR line breaks, but I can't imagine they'd do something that stupid...

EDIT: I just checked a random sampling of the files from my local sources, and they are all LF (which I would tend to agree with when working with Java tools). Maybe yours got changed to CRLF somehow or they got fudged when pushed into the repository?
« Last Edit: August 23, 2007, 12:41:49 AM by devSin »

 

With Quick-Reply you can write a post when viewing a topic without loading a new page. You can still use bulletin board code and smileys as you would in a normal post.

Warning: this topic has not been posted in for at least 120 days.
Unless you're sure you want to reply, please consider starting a new topic.

Name: Email:
Verification:
Type the letters shown in the picture
Listen to the letters / Request another image
Type the letters shown in the picture:
What color are clouds?:
What is the fourth word in this sentence?: